[Perdition's Reprieve] - Arms

There appears to be a slight flaw in the CS uptime ticker, but can't work the syntax out.
Line 71 appears to keep casting colossus smash, even if the debuff is up ~1/2 through debuff

if (await S.Cast(SB.spellColossusSmash, !U.colossusSmash)) return true;

 

you can change that line to:

Code:

if (await S.Cast(SB.spellColossusSmash, !currentTarget.auraExists(SB.spellColossusSmash))) return true;

until he decides to implement a fix

 

I'll need to take a look and add in some logging to verify casting. Personally I don't see this overlap happening but, I have yet to test with Enyo either.

 

The call !U.colossusSmash equals the same thing as your post. Are you also seeing this overlap? Could be possible that the cache isn't updating correctly.

 

I can verify it is throwing CS about 1/2 through CS or WB. Will try some more testing testing/tweaking.

 

Found it. Tactics.cs Line 192 for the single target rotation

if (await S.Cast(SB.spellColossusSmash, !U.shatteredDefenses)) return true;

This was causing CS to cast on CD if Shattered Defenses was not up try to force a proc. Changed to this and it was casting at the end of debuff.

if (await S.Cast(SB.spellColossusSmash, !U.colossusSmash)) return true;

Going to try and wrap some more logic around it to cast when the buff is about to fall off, so it hits for added damage & applying same logic to warbringer artifact talent cast. That is unless someone can spell out why this is bad?

 

Currently I am following SimC for the rotation but, I do see your point in an overlap to allow the initial damage to make use of the already existing debuff (assuming it can make use of it). Please let me know what you find to be best and I can create variations if needed.

 

Dagradt ,
The rotation is fine. You need to Refresh CS just Before Mortal Strike to benefit from Shattered Defenses. You dont need to let full duration of CS run. This is how simcraft works and even you should Mortal strike on CD even if you have 1 stack or 2 of Focused Rage.

 

With the nerf to tactician today, going to see how the cards fall. With the reduced procs, may need to keep CS up as long as possible.

 

So when is the CS fix coming?

 

Any news about this routine ? Actually not bad, but can do better i think ^^ Keep the work it's nice job

 

Public Update:

>> Update: 10/08/2016 <<
​

[Perdition's Reprieve] - Arms will be rolled into [Perdition's Reprieve] - Warrior along with full updates to each spec in accordance with the patchwork level simulations given by SimC and user requests. Please be aware that there may be a brief momentary lapse of time in which none of the Warrior specifications may be available during the transition to the new core.​

 

Do you need a hand for alpha testing?

 

If you havn't already looked at specialization changes while the bot is on, let me know I can supply you with the code. Didn't really want to copy pasta here though.

 

Please PM me.

 

I'm using a rather simple method currently but, it may be adding extra weight to the tick process. Please PM me.

 

Any status update on this?
How's it working?

 

Playing with different rotations currently and ideas. Making tweaks as my testers give feedback.

 

So anxiously waiting release, this will be awesome indeed as I have trouble with the FR rotation currently as Arms

 

With charge being a big part of generating rage in down time, could it be possible to add a visual or audio queue for it? Since the CR doesn't handle movement and I haven't quite got the timing down for it either. Thanks