• Visit Rebornbuddy
  • CLU (Codified Likeness Utility)

    Discussion in 'Archives' started by wulf, Feb 18, 2012.

    Thread Status:
    Not open for further replies.
    1. wulf

      wulf Community Developer

      Joined:
      Dec 29, 2010
      Messages:
      1,832
      Likes Received:
      128
      Trophy Points:
      63
      Last edited: Aug 28, 2012
    2. weischbier

      weischbier Guest

      hm ... ok, but I like it anyway :D

      greetz

      Weischbier
       
    3. wulf

      wulf Community Developer

      Joined:
      Dec 29, 2010
      Messages:
      1,832
      Likes Received:
      128
      Trophy Points:
      63
      Cheers
      Weischbier, let me know if he has the speed
      :cool:
       
    4. derfred

      derfred New Member

      Joined:
      Jun 14, 2010
      Messages:
      34
      Likes Received:
      1
      Trophy Points:
      0
      I just tried it, and for me it lagged really bad, spikelags just about every 2 seconds or so. I tried both Retri Paladin and Deathknight Unholy, and tried them both with Combat Bot and Lazyraider.

      Ive never experienced spikelags like this earlier and I have plenty of ram in computer, only time it lags is when i run this CC.
       

      Attached Files:

    5. Akafist

      Akafist New Member

      Joined:
      Apr 8, 2011
      Messages:
      24
      Likes Received:
      0
      Trophy Points:
      1
      Thank you for this new cc. It works for me like a charm. Running with my lvl 84 bear through cata instances and it works flawlessly!
       
    6. Bayoya

      Bayoya New Member

      Joined:
      May 12, 2010
      Messages:
      586
      Likes Received:
      0
      Trophy Points:
      0
      Awww no rogues /cry
       
    7. wulf

      wulf Community Developer

      Joined:
      Dec 29, 2010
      Messages:
      1,832
      Likes Received:
      128
      Trophy Points:
      63
      Thanks derfred. And thank-you for attaching your log :)

      Unholy was untested so I missed this problem!

      CLU has a problem with identifying these spells.
      Code:
      System.Collections.Generic.KeyNotFoundException: The specified spell could not be found: Sudden Doom
      System.Collections.Generic.KeyNotFoundException: The specified spell could not be found: Death Coil
      
      I am looking at it now.
       
    8. okeofs

      okeofs New Member

      Joined:
      Jan 15, 2010
      Messages:
      303
      Likes Received:
      1
      Trophy Points:
      0
      This D:
       
    9. Toney001

      Toney001 New Member

      Joined:
      Oct 12, 2011
      Messages:
      1,206
      Likes Received:
      5
      Trophy Points:
      0
      Nice Wulf, I love your work :).
      Will this be some sort of Felmaster continuation?
       
    10. bhardegger

      bhardegger Member

      Joined:
      Oct 5, 2010
      Messages:
      44
      Likes Received:
      2
      Trophy Points:
      8
      Wulf,

      tested on a dummy with my usual folder and had massive drops in FPS from 60+ down to 7 FPS. did a clean install of HB and your CC from SVN and it did get somewhat better it only dropped down to 11 FPS. this was done with your frost CC. good thing is even with the crap FPS was still pulling 19k as a 386 iLVL so i have high hopes for this. the log is attached
       

      Attached Files:

    11. weischbier

      weischbier Guest

      I noticed that too, i'll come up with a complete Analysis later this day!
       
    12. CodenameG

      CodenameG New Member

      Joined:
      Jan 15, 2010
      Messages:
      38,369
      Likes Received:
      231
      Trophy Points:
      0
      Code:
      
      public override void Pulse()          {              ObjectManager.Update();             //Helpers.Buff.DumpAuras();         } 
      
      you dont have to force objectmanager to update, it updates every pulse. and since thats all you have in the pulse, it makes it redundant.
       
    13. wulf

      wulf Community Developer

      Joined:
      Dec 29, 2010
      Messages:
      1,832
      Likes Received:
      128
      Trophy Points:
      63

      Thanks Toney001. In no way is this a continuation of felmasters work, as it is respected in its own right.
      Rather this is my adaptation of existing work melded into a project I can update as honourbuddy evolves.
      I have also tried to remove as much Lua as possible so that it will grow as HB grows.



      Thanks bhardegger. This is why I asked in my template what sort of a system users have as this CC can be taxing.
      I will look into this - I will start with removing the ObjectManager.Update() from the pulse.
      I could also be using Framelock incorrectly.
      It does not help that this CC was developed on a beast (16g ram, I7 2600K OC, 2x SSDs in Raid 0 and a GTX 590)
      Stay tuned...



      Thanks CodenameG, your input is greatly appreciated. I will remove.
       
      Last edited: Feb 19, 2012
    14. bhardegger

      bhardegger Member

      Joined:
      Oct 5, 2010
      Messages:
      44
      Likes Received:
      2
      Trophy Points:
      8
      Wulf,

      It very well could be my system as i am running it on a laptop with a core i5, 8gb ram and a 560m. i do not have my desktop available atm as i am moving around the world so i will not be able to test until a later date.
       
    15. wulf

      wulf Community Developer

      Joined:
      Dec 29, 2010
      Messages:
      1,832
      Likes Received:
      128
      Trophy Points:
      63
      Excellent post. I am looking into the performance problems.
       
    16. weischbier

      weischbier Guest

      Ok here we go:

      Honorbuddy version: Latest!
      Class: DeathKnight (masterfrost)
      Level: 85
      Group: Dummy testing
      My Latency is: < 45ms
      My Computer is: 2 Months old and it was a hell of a birth! (i7, 12 GB RAM (1600MHZ),No SSDs but 10k rpm HDD, ATI Radeon HD 6970M => Laptop)
      Made any changes: Removed Pulse since it is obsolete
      Issue/Bug/Problem/Suggestion: FPS jumpers

      So I tested this for 10min straight and NEVER broke the 20k DPS wall.
      The FPS freezes from time to time in a 2 - 3 s rythm.
      What I saw is that you check way to much.
      It freezes every time on the following checks:
      Code:
      [10:51:59:341] [CLU] 2.0.1 RuneCooldown: -> Unholy_2 has 0 seconds left
      [10:51:59:385] [CLU] 2.0.1 RuneCooldown: -> Unholy_1 has 4 seconds left
      [10:52:00:525] [CLU] 2.0.1 RuneCooldown: -> Unholy_1 has 3 seconds left
      
      Code:
      [10:52:01:809] [IsTargetWorthy] Raider's Training Dummy is a boss? True or miniBoss? False or Training Dummy? True. Raider's Training Dummy current Health = 147872040
      
      I think you cause some overusing og HBs framelock ability. Since you are returning so much values and printing them to the log it causes HB to get at certain values to slow down so hard and locking a single frame for more then half a second.

      My suggestion is to reduce some checks in your CanCast() and not to return so much time based values.
      Latenzy and Powercost, I think are not neccessary checks.


      greetz

      Weischbier
       
    17. wulf

      wulf Community Developer

      Joined:
      Dec 29, 2010
      Messages:
      1,832
      Likes Received:
      128
      Trophy Points:
      63
      Weischbier thank you very much for taking the time to test this CC, I really value your input.

      I have just updated to 2.02 which removes obsolete pulse and Framelock is now gone.

      EDIT:
      Ok Death Coil isssue resolved !!! http://www.thebuddyforum.com/honorbuddy-forum/developer-forum/45425-keynotfoundexception-specified-spell-could-not-found-death-coil.html#post469519

      Thank you again, its only early stages...please give feedback for the remainder of the classes implemented!

      Feral Cat is quite good, 60k on Madness with ilvl 370.
       
      Last edited: Feb 19, 2012
    18. handnavi

      handnavi Well-Known Member Buddy Store Developer

      Joined:
      Jan 15, 2010
      Messages:
      2,489
      Likes Received:
      59
      Trophy Points:
      48
      Hey wulf!

      I have to say that i have not tested this so far, i just read through your code.

      I came to the following line:
      Code:
      
      Items.RunMacroText("/cast Ravage",.....);
      Does this work? Shouldnt it be
      Code:
      
      Items.RunMacroText("/cast Ravage[COLOR=#ff0000]![/COLOR]",.....); 
      ? :)

      You can also easily get rid of this macro if you would cast this spell by id.

      Cheers
       
    19. laria

      laria Well-Known Member

      Joined:
      Jan 15, 2010
      Messages:
      5,386
      Likes Received:
      36
      Trophy Points:
      48
      is hb not able to cast it with the spellmanager and the "name"`?
       
    20. handnavi

      handnavi Well-Known Member Buddy Store Developer

      Joined:
      Jan 15, 2010
      Messages:
      2,489
      Likes Received:
      59
      Trophy Points:
      48
      No. ;)
       
    Thread Status:
    Not open for further replies.

    Share This Page