[Orderbot] [Plugin] [Fish v3.0+] and profiles support thread

Thanks! I might have missed it while scurrying the forum looking for a fix.

 

Sorry newbie question because I am currently making my own fishing profile. I have some issues where my guy isn't close enough to the edge to start fishing, like if he takes a step or two he will be able to cast Hook. What can I do to stop that from happening? I have already taken coordinates where I am at the edge, but after dismounting he doesn't move forward that little bit to cast Hook. Also what is heading?

 

So I was running the ephemeral fishies profile all day and somehow my game completely locks up when a certain ExBuddy function is used. Right at the end here with the directions. If I stop the bot, my game will un-freeze.

Code:

[00:08:22.922 V] [FlightNav] Replacing Navigator with Flight Navigator.
[00:08:22.922 N] [EnableFlight] Started Flight Navigator.
[00:08:25.698 D] DoAction Spell 299 0x100379C5
[00:08:28.503 V] [Poi.Clear] Reason: Current behavior changed to ExLogTag.
[00:08:28.503 D] Replaced hook [ProfileOrderBehavior_Hook] 6ecb6be7-ae7b-4a02-be53-18cfbfb52188
[00:08:28.504 N] [Tour Guide] Skywatcher reporting weather isn't optimal for Dravanian Bass at this time.
[00:08:28.561 V] [Poi.Clear] Reason: Current behavior changed to ExLogTag.
[00:08:28.561 D] Replaced hook [ProfileOrderBehavior_Hook] 095aa47d-920c-4dda-a083-c220dffcac7e
[00:08:28.561 N] [Tour Guide] Will fish for Illuminati Perch until 7am in Dravanian Hinterlands.
[00:08:28.619 N] [ExFish v3.1.0.1511240] Shuffled fish spots
[00:08:28.621 V] [Poi.Clear] Reason: Current behavior changed to ExFishTag: { Baits: [Bait: { Name: Brute Leech }, Bait: { Name: Goblin Jig }, Bait: { Name: Stonefly Nymph }], Keepers: [Keeper: { Name: Illuminati Perch }], Collectables: [Collectable: { Name: Illuminati Perch, Value: 826 }], FishSpots: [FishSpot: { Heading: 4.83, Location: <-1.49358E+07, 100.6385, -165.193> }, FishSpot: { Heading: 5.95, Location: <-143.9319, 100.6229, -157.005> }], MoochLevel: 1, MinimumFishPerSpot: 35, MaximumFishPerSpot: 45, Condition: IsTimeBetween(0,7), Shuffle: True, SitRate: 0.75, Patience: Patience, PatienceTugs: [PatienceTug: { TugType: Light }, PatienceTug: { }, PatienceTug: { MoochLevel: 1 }], LineNumber: 359 }.
[00:08:28.621 D] Replaced hook [ProfileOrderBehavior_Hook] 90222309-b5ba-4529-bc61-12bcf08a7dc6
[00:08:28.641 D] DoAction Mount 48 0xE0000000
[00:08:30.257 D] Requesting path on 399 from <-221.5171, 104.3267, -600.1479> to <-1.49358E+07, 100.6385, -165.193>
[00:08:30.338 D] No viable path from <-221.5171, 104.3267, -600.1479> to <-1.49358E+07, 100.6385, -165.193> in 00:00:00.0808915 ms
[00:08:30.412 N] [FlightNav] Generating path on 399 from <-221.5171, 104.3267, -600.1479> to <-1.49358E+07, 100.6385, -165.193>
[00:08:30.427 V] [ExBuddy] Direction of deviation: ForwardUp
[00:08:30.432 V] [ExBuddy] Direction of deviation: ForwardRight
[00:08:30.467 V] [ExBuddy] Direction of deviation: ForwardUp
[00:08:30.471 V] [ExBuddy] Direction of deviation: ForwardRight

 

You are on the wrong map, I suggest bringing up the issue with the author of the profile 399 is not the hinterlands, i believe that is 398. The flight navigator is not friendly enough to tell you when somewhere is not reachable, it just continues to try to find a way to get there.

 

Chinese client，
After selecting the bait,
Cannot close the selection interface
Cannot swing fishing

thanks

 

I'm getting an issue with the profiles where Skywatcher isn't predicting weather data accurately. For example, SkywatcherPlugin.IsWeatherInZone(398, 3) will return true even when the weather in Drav Forelands is Clear Skies.
This has persisted for a while for me; not sure if anyone else is getting the same thing.

Also, could you post the Rebornconsole commands that work with the current version of your plugins? In one of your posts a while back you mentioned like

Code:

Log(SkywatcherPlugin.WeatherProvider.CurrentWeatherData.First(w => w.ZoneId == 146).Weather);

but that does not appear to work anymore.

 

You will have to use something like.

Code:

Log(ExBuddy.Plugins.Skywatcher.Skywatcher.WeatherProvider.CurrentWeatherData.First(w => w.ZoneId == 146).Weather);
Log(ExBuddy.Helpers.SkywatcherPlugin.IsWeatherInZone(146, "Heat Waves"));
Log(ExBuddy.Helpers.SkywatcherPlugin.PredictWeatherInZone(146, TimeSpan.FromHours(6), "Heat Waves"));
Log(ExBuddy.Helpers.SkywatcherPlugin.PredictWeatherInZone(398, TimeSpan.FromHours(8), 4));
Log(ExBuddy.Helpers.SkywatcherPlugin.IsWeatherInZone(398, 3, 4, 11));
Log(ExBuddy.Helpers.SkywatcherPlugin.IsWeatherInZone(398, 1, 2));

On the other note of it not working. It could be an issue with the website.

 

Thank you for the code.
In regards to the second issue, for example right now http://en.ff14angler.com/skywatcher/ accurately shows Drav Forelands from 0:00 to to 8:00 as Clear skies, but

Code:

Log(ExBuddy.Plugins.Skywatcher.Skywatcher.WeatherProvider.CurrentWeatherData.First(w => w.ZoneId == 398).Weather);

returned Fog from 0:00 to ~02:30, then switched to Clear Skies

The website does show fog for Drav Forelands from 16:00 to 0:00; I'm not sure if the plugin is lagging by a couple hours or something. I'll keep testing to see if there's a pattern.

Edit: There does appear to be a lag; Mor Dhona was Gloom from 0-8 and Clear from 8-16, but still showed as Gloom in Skywatcher.WeatherProvider at 9.
Likewise, Sea of Clouds was Fair from 0-8 and Clouds from 8-16, but showed as Fair after 8. Skywatcher plugin did not reflect the accurate weather for 8-16 until ~9:45.

 

It is working within 3 or so eorzea minutes for me.

1. What time zone are you in?
2. What is the result of Log(WorldManager.EorzaTime); vs true in game eorzea time.
3. Does this value look correct to you compared to in game eorzea time Log(ExBuddy.Helpers.SkywatcherPlugin.GetEorzeaTimeTillNextInterval());

 

1) Central time
2), 3) are both accurate as far as I can tell.

Most recent weather switch was updated within 1 Eorzean minute, so I'm not sure what the pattern is. I'll try reinstalling and keep an eye on things, and see what happens. Thanks for your help.

 

Hinterlands is 399.

I suggested to Sinanju when it was brought it up in the profile thread to re-do his hotspot. I'm guessing it wasn't set up correctly, but as I've yet to hear back since he posted I can't be sure. I'd like to see the fishspots that were entered in that area, I think that's where we will find the issue.

 

Getting the same issue with skywatcher again; can't figure out why it works sometimes and not othertimes. See linked image: http://i.imgur.com/HuiI9P0.png

I'm sitting in Tailfeather as shown by the map, and the weather is in the middle of a dust clouds window, but SkywatcherPlugin thinks its thunder. The Skywatcher website does reflect the accurate weather for the window.

 

I found an issue with skywatcher where it will not update at the proper time after running for a while. I'm not sure what strategy I will use to fix it yet. I will need to do more research.

In my private profiles for now, I am putting in the following code before my fish tags.

Code:

<ExDisablePlugins names="Skywatcher" />
<WaitTimer waitTime="1" />
<ExEnablePlugins names="Skywatcher" />

This should help most of the issues for now.

 

Hm alright, thanks for looking into it. I'm just glad it wasn't only me haha.

 

hi exmatt Please answer me?

O(∩_∩)O谢谢 very thanks

 

I would either need someone to find me the selected bait offset in the CN ffxiv client or mastahg find a way to get it for all languages. I have no way to do this myself, sorry.

 

Thank you, I know.

 

I started using the above in a profile I'm working on. Ran into something I haven't seen before with Skywatcher in my log. Maybe you've seen this wall of red about a null exception before. Happens going into a zone right after Skywatcher passes the conditions are met I think, because it teleports to the zone only when conditions are right. Come to think of it, I stuck it right in front of the fish tag... like:

Code:

<ExDisablePlugins names="Skywatcher" />
				<WaitTimer waitTime="1" />
				<ExEnablePlugins names="Skywatcher" />					
				<Fish Condition="Condition.IsTimeBetween(0.5,7) and SkywatcherPlugin.IsWeatherInZone(398, 3, 4, 11)" 
					minFish="35" maxFish="45" 
					Patience="Patience"
					snagging="true"
					collect="true"
					shuffleFishSpots="true"
					sitRate=".75"
					mooch="0">

And I get this:

Code:

[02:32:28.104 N] Plugin Skywatcher has been enabled.
[02:32:28.110 D] System.ArgumentNullException: Value cannot be null.
Parameter name: source
   at System.Linq.Enumerable.Where[TSource](IEnumerable`1 source, Func`2 predicate)
   at ExBuddy.Plugins.Skywatcher.FF14AnglerWeatherProvider.get_CurrentWeatherData() in c:\Users\Dad\Documents\Rebornbuddy\Plugins\ExBuddy.git\trunk\ExBuddy\Plugins\Skywatcher\FF14AnglerWeatherProvider.cs:line 76
   at ExBuddy.Helpers.SkywatcherPlugin.IsWeatherInZone(Int32 zoneId, Byte[] weatherIds) in c:\Users\Dad\Documents\Rebornbuddy\Plugins\ExBuddy.git\trunk\ExBuddy\Helpers\SkywatcherPlugin.cs:line 66
   at Microsoft.Scripting.Interpreter.FuncCallInstruction`3.Run(InterpretedFrame frame)
   at Microsoft.Scripting.Interpreter.Interpreter.Run(InterpretedFrame frame)
   at Microsoft.Scripting.Interpreter.LightLambda.Run7[T0,T1,T2,T3,T4,T5,T6,TRet](T0 arg0, T1 arg1, T2 arg2, T3 arg3, T4 arg4, T5 arg5, T6 arg6)
   at System.Dynamic.UpdateDelegates.UpdateAndExecute6[T0,T1,T2,T3,T4,T5,TRet](CallSite site, T0 arg0, T1 arg1, T2 arg2, T3 arg3, T4 arg4, T5 arg5)
   at Microsoft.Scripting.Interpreter.DynamicInstruction`7.Run(InterpretedFrame frame)
   at Microsoft.Scripting.Interpreter.Interpreter.Run(InterpretedFrame frame)
   at Microsoft.Scripting.Interpreter.LightLambda.Run1[T0,TRet](T0 arg0)
   at IronPython.Compiler.PythonCallTargets.OriginalCallTarget0(PythonFunction function)
   at System.Dynamic.UpdateDelegates.UpdateAndExecute1[T0,TRet](CallSite site, T0 arg0)
   at _Scripting_(Object[] )
   at ExBuddy.OrderBotTags.Fish.ExFishTag.ConditionCheck() in c:\Users\Dad\Documents\Rebornbuddy\Plugins\ExBuddy.git\trunk\ExBuddy\OrderBotTags\Fish\ExFishTag.cs:line 1106
   at ExBuddy.OrderBotTags.Fish.ExFishTag.<get_Conditional>b__64(Object ret) in c:\Users\Dad\Documents\Rebornbuddy\Plugins\ExBuddy.git\trunk\ExBuddy\OrderBotTags\Fish\ExFishTag.cs:line 1016
   at TreeSharp.Decorator.CanRun(Object context)
   at TreeSharp.Decorator.<Execute>d__12.MoveNext()
   at TreeSharp.Composite.Tick(Object context)
   at TreeSharp.PrioritySelector.<Execute>d__2.MoveNext()
   at TreeSharp.Composite.Tick(Object context)
   at TreeSharp.PrioritySelector.<Execute>d__2.MoveNext()
   at TreeSharp.Composite.Tick(Object context)
   at ff14bot.Behavior.HookExecutor.Run(Object context)
   at TreeSharp.Action.RunAction(Object context)
   at TreeSharp.Action.<Execute>d__13.MoveNext()
   at TreeSharp.Composite.Tick(Object context)
   at TreeSharp.PrioritySelector.<Execute>d__2.MoveNext()
   at TreeSharp.Composite.Tick(Object context)
   at TreeSharp.PrioritySelector.<Execute>d__2.MoveNext()
   at TreeSharp.Composite.Tick(Object context)
   at ff14bot.Behavior.HookExecutor.Run(Object context)
   at TreeSharp.Action.RunAction(Object context)
   at TreeSharp.Action.<Execute>d__13.MoveNext()
   at TreeSharp.Composite.Tick(Object context)
   at TreeSharp.Decorator.<Execute>d__12.MoveNext()
   at TreeSharp.Composite.Tick(Object context)
   at TreeSharp.PrioritySelector.<Execute>d__2.MoveNext()
   at TreeSharp.Composite.Tick(Object context)
   at ff14bot.TreeRoot.()
[02:32:28.166 D] System.ArgumentNullException: Value cannot be null.
Parameter name: source
   at System.Linq.Enumerable.Where[TSource](IEnumerable`1 source, Func`2 predicate)
   at ExBuddy.Plugins.Skywatcher.FF14AnglerWeatherProvider.get_CurrentWeatherData() in c:\Users\Dad\Documents\Rebornbuddy\Plugins\ExBuddy.git\trunk\ExBuddy\Plugins\Skywatcher\FF14AnglerWeatherProvider.cs:line 76
   at ExBuddy.Helpers.SkywatcherPlugin.IsWeatherInZone(Int32 zoneId, Byte[] weatherIds) in c:\Users\Dad\Documents\Rebornbuddy\Plugins\ExBuddy.git\trunk\ExBuddy\Helpers\SkywatcherPlugin.cs:line 66
   at Microsoft.Scripting.Interpreter.FuncCallInstruction`3.Run(InterpretedFrame frame)
   at Microsoft.Scripting.Interpreter.Interpreter.Run(InterpretedFrame frame)
   at Microsoft.Scripting.Interpreter.LightLambda.Run7[T0,T1,T2,T3,T4,T5,T6,TRet](T0 arg0, T1 arg1, T2 arg2, T3 arg3, T4 arg4, T5 arg5, T6 arg6)
   at Microsoft.Scripting.Interpreter.DynamicInstruction`7.Run(InterpretedFrame frame)
   at Microsoft.Scripting.Interpreter.Interpreter.Run(InterpretedFrame frame)
   at Microsoft.Scripting.Interpreter.LightLambda.Run1[T0,TRet](T0 arg0)
   at _Scripting_(Object[] )
   at ExBuddy.OrderBotTags.Fish.ExFishTag.ConditionCheck() in c:\Users\Dad\Documents\Rebornbuddy\Plugins\ExBuddy.git\trunk\ExBuddy\OrderBotTags\Fish\ExFishTag.cs:line 1106
   at ExBuddy.OrderBotTags.Fish.ExFishTag.<get_Conditional>b__64(Object ret) in c:\Users\Dad\Documents\Rebornbuddy\Plugins\ExBuddy.git\trunk\ExBuddy\OrderBotTags\Fish\ExFishTag.cs:line 1016
   at TreeSharp.Decorator.CanRun(Object context)
   at TreeSharp.Decorator.<Execute>d__12.MoveNext()
   at TreeSharp.Composite.Tick(Object context)
   at TreeSharp.PrioritySelector.<Execute>d__2.MoveNext()
   at TreeSharp.Composite.Tick(Object context)
   at TreeSharp.PrioritySelector.<Execute>d__2.MoveNext()
   at TreeSharp.Composite.Tick(Object context)
   at ff14bot.Behavior.HookExecutor.Run(Object context)
   at TreeSharp.Action.RunAction(Object context)
   at TreeSharp.Action.<Execute>d__13.MoveNext()
   at TreeSharp.Composite.Tick(Object context)
   at TreeSharp.PrioritySelector.<Execute>d__2.MoveNext()
   at TreeSharp.Composite.Tick(Object context)
   at TreeSharp.PrioritySelector.<Execute>d__2.MoveNext()
   at TreeSharp.Composite.Tick(Object context)
   at ff14bot.Behavior.HookExecutor.Run(Object context)
   at TreeSharp.Action.RunAction(Object context)
   at TreeSharp.Action.<Execute>d__13.MoveNext()
   at TreeSharp.Composite.Tick(Object context)
   at TreeSharp.Decorator.<Execute>d__12.MoveNext()
   at TreeSharp.Composite.Tick(Object context)
   at TreeSharp.PrioritySelector.<Execute>d__2.MoveNext()
   at TreeSharp.Composite.Tick(Object context)
   at ff14bot.TreeRoot.()
[02:32:28.524 D] DoAction Mount 1 0xE0000000

Do you think it needs more time to finish reading or somesuch? Maybe a wait after the load before doing the fishtag? It doesn't affect anything other than the log really, the check already passed. It's just red.

 

Yes, i would try adding in a 1 second wait after enabling it.

 

Also, instead of fixing the ff14 angler provider I am using, I started working on importing the stuff garland tools uses (from SaintCoinach).