• Visit Rebornbuddy
  • FightThisWay

    Discussion in 'All in One' started by Kamilche, Oct 14, 2012.

    1. blancharke

      blancharke Member

      Joined:
      Jan 15, 2010
      Messages:
      225
      Likes Received:
      4
      Trophy Points:
      18
      With the latest update autoattack wasnt working anymore. Started noticing when i made a fresh toon.
      Replaced this code
      Code:
      private bool On_AutoAttack()            {
                      string fnname = "MBC.On_AutoAttack";
                      MyTimer.Start(fnname);
                      if (!StyxWoW.Me.IsAutoAttacking && StyxWoW.Me.CurrentTarget != null && StyxWoW.Me.IsValidUnit())
                      {
                          log("	AutoAttack");
                          Lua.DoString("StartAttack()");
                      }
                      MyTimer.Stop(fnname);
                      return false;
                  }
      back with the old one and its working fine again
       
    2. metisgb

      metisgb New Member

      Joined:
      Apr 14, 2010
      Messages:
      66
      Likes Received:
      0
      Trophy Points:
      0
      kamilche,

      the elemental shaman spec pops "ascendance".. and then does nothing.. soon as it wears off, she will proceed to own again.. possible bug?

      -metis
       
    3. ynoorbz

      ynoorbz Member

      Joined:
      Nov 24, 2010
      Messages:
      114
      Likes Received:
      2
      Trophy Points:
      18
      Omg I dont know how I havent noticed this before. I think you may have just solved my problem of getting a Combat Routine that I could edit myself to simply pull with Ice Lance and Fire Blast on my mage to grind low lvl syndicate mobs for my insane title. Thank you soooo much ;)
       
    4. Mupp

      Mupp New Member

      Joined:
      May 3, 2010
      Messages:
      613
      Likes Received:
      5
      Trophy Points:
      0
      Rogue stealths when mounted, happens like every 5 sec after its succesfully is mounted and moving. Not seen it before in the last revisions.
      Thanks again for this great contribution mate :)
       
    5. Nevaehstar

      Nevaehstar New Member

      Joined:
      Feb 20, 2012
      Messages:
      4
      Likes Received:
      0
      Trophy Points:
      0
      I's working great except no matter how I set it up my warrior refuses to use Impending Victory.

      Edit: Got it working by using "victory rush" instead. The problem now is that it keeps trying to spam it without recognizing or skipping the ability after using it. (Has 30 second Cooldown)
       
      Last edited: Oct 30, 2012
    6. Kamilche

      Kamilche New Member

      Joined:
      Oct 2, 2010
      Messages:
      551
      Likes Received:
      30
      Trophy Points:
      0
      Uh, you can see how many plugins I don't use here! :-D I don't use LazyRaider, but I hear if you toggle the 'framelock' option it works OK.

      But - I did change the custom class, so it's much more timid on using the 'follow tank logic.' It shouldn't try to do it any more unless you're in 'grind bot' mode while in a party. Let me know if that fixed it for you.
       
    7. Kamilche

      Kamilche New Member

      Joined:
      Oct 2, 2010
      Messages:
      551
      Likes Received:
      30
      Trophy Points:
      0
      That is weird. You know how WoW leaves you in 'combat' mode sometimes when you're not really in combat? I would continually get the message 'I don't have a target'. 'That requires a target.' when it happened, so I added that bit in there to disable the voice spam.

      The only difference between that, and the old one, is the addition of 'target != null' and 'target.isvalidunit'. Try adding the new code back in, but leave off the 'isvalidunit' check - just make it the 'not null' check. Does it still work for you on autoattack? If so, that's what I'll keep.

      BTW - what was your new toon class/spec? I could check this out myself if I knew what class was failing.
       
    8. Kamilche

      Kamilche New Member

      Joined:
      Oct 2, 2010
      Messages:
      551
      Likes Received:
      30
      Trophy Points:
      0
      Yeah, that's a problem - I'll fix it when I get home tonight.
       
    9. Kamilche

      Kamilche New Member

      Joined:
      Oct 2, 2010
      Messages:
      551
      Likes Received:
      30
      Trophy Points:
      0
      Glad you like it! I have a custom class file that does nothing but kitty 'Swipe' myself, to grind frostweave in Cathedral of Darkness. Swipe till you die, or win - and if you don't stop, it's usually 'win.' Then heal during rest only.
       
    10. Kamilche

      Kamilche New Member

      Joined:
      Oct 2, 2010
      Messages:
      551
      Likes Received:
      30
      Trophy Points:
      0
      OK, I will look at the following when I get home tonight:

      Code:
      Mages with Invocation
      	Cast Evocation when Invoker's Energy buff is missing
      Discipline Priest
      	Cast mind sear when 5+ mobs around
      
      Remove party member names from log file
      
      Elemental shaman pops 'ascendance' then does nothing.
      
      Rogue stealths when mounted - bad bad bad!
      
      Warrior doesn't use 'impending victory.' By using 'victory rush' it works, but it keeps trying to spam it without recognizing or skipping the ability after using it.
      
      
      I'll let you know when a revised version is uploaded.
       
    11. PhaseRoll

      PhaseRoll New Member

      Joined:
      Oct 29, 2012
      Messages:
      48
      Likes Received:
      0
      Trophy Points:
      0
      Is there any way to optimize the Monk Windwalker.txt? cause at the moment the default that came with it is pretty bad

      I monitored my toon while its botting using both BGBuddy + FightThisWay and the skill rotations are off - it doesnt cast RSK, doesnt use Tiger Palm or BOK when Combo Breaker procs and stuff like that

      Advices would be great

      Thanks
       
    12. Fazc

      Fazc Member

      Joined:
      Jun 18, 2010
      Messages:
      124
      Likes Received:
      1
      Trophy Points:
      18
      Very, very effective routine for a Balance Druid.
       
    13. Kamilche

      Kamilche New Member

      Joined:
      Oct 2, 2010
      Messages:
      551
      Likes Received:
      30
      Trophy Points:
      0
      OK, I've changed things based on your suggestions, and the latest release is available for download.
      Changes include:

      Code:
      
      Mages (All) with Invocation (level 90, couldn't test)
      	Cast Evocation when Invoker's Energy buff is missing
      
      Priests (All)
      	Cast Mind Sear when 5+ mobs around
      
      Shaman (Elemental, Enhancement)
      	Added 'Lava Beam' and 'Stormblast' to elemental and enhancement classes, to be used during 'Ascendance.'
      
      Rogues (All)
      	Removed stealth from rogue's rest routine
      
      Warrior (All)
      	Victory Rush appeared broken. Actually, all movement for melee classes was broken with last night's update, but it looked like something else.
      	Now fixed.
      
      Monk Windwalker needs attention
      	RSK, doesnt use Tiger Palm or BOK when Combo Breaker procs and stuff like that
      
      Remove party member names from log file
      
      
      I've optimized the Monk Windwalker routine so it uses more procs. In a non-heroic dungeon, I had top DPS. In a heroic dungeon with a 435 item score (barely enough to enter), I went between 30,000 and 33,000 dps and ended up 2nd in dungeon DPS overall, behind a mage. It looks pretty good to me, but if you see some room for improvement, give me a holler.

      Could use some help testing the Mage change, as I don't have a level 90 mage yet.

      Could also use another set of eyeballs on the log files, make sure no names of players are in there. I even removed the 'red text' logging, because it would say 'Soandso has left the raid group' at the end of dungeons. Didn't use that for anything anyway.

      Finally, if you're melee and downloaded it yesterday, download it again! Melee movement was broken (the warrior 'victory rush' problem was actually a movement problem in disguise.)
       
      Last edited: Oct 31, 2012
    14. Ramakandra

      Ramakandra New Member

      Joined:
      Oct 18, 2012
      Messages:
      49
      Likes Received:
      1
      Trophy Points:
      0
      Kamilche, thank you very much for you fine work!
      Here is some feedback for Enhance Shaman, i keep getting:
      Code:
      [05:57:52.483 D] [FTW] 02:57:52 CanCast returned false for Stormblast 115356 on Training Dummy health 50.0 dist 2.9
      
      Until i added Stormblast to Spell_Ignore_CanCast.txt

      Then i was getting:
      Code:
      [05:54:33.769 D] [FTW] 02:54:33 Unknown spell Stormstrike
      
      I know its something to do with Spell_Overrides.txt, the log says:

      Code:
      [06:02:17.500 D] [SpellManager] Stormstrike (17364) overrides Primal Strike (73899)
      [05:53:22.516 D] [FTW] 02:53:22 Unknown spell Stormstrike
      
      So i added:

      Code:
      17364 8 Stormstrike
      
      To Spell_Overrides.txt and now it works ok, last thing:

      Code:
      Lightning Bolt
      	Me.StackCount("Maelstrom Weapon") = 5
      
      Stop working randomly and i've tried everything but after a few time it stops working at all.

      The log says:
      Code:
      [06:24:15.009 D] [FTW] 03:24:15 +++ Maelstrom - 0 stacks, 29.9 seconds remaining
      
      I suspect something in HB is not detecting the stack of Maelstrom Weapon,
       
      Last edited: Oct 31, 2012
    15. Kamilche

      Kamilche New Member

      Joined:
      Oct 2, 2010
      Messages:
      551
      Likes Received:
      30
      Trophy Points:
      0
      Hey, that's handy, thanks. My shamans are still 85 so it's impossible to fully test this at the moment.

      It looks like you got a buff called 'Maelstrom', not 'Maelstrom Weapon.' Change the 'Lightning Bolt' condition to check for 'Maelstrom' instead of 'Maelstrom Weapon', and that should fix it.

      I've fixed it in my files and reuploaded. Druid Resto was messed up because Swiftmend started failing - I had to add it to the 'Ignore_Cancast' file as well. Some other spells are acting oddly - Cenarion Ward is attempting to cast though I don't have the talent, so I had to put another condition on that.

      Anyways - thanks for the catch!

       
    16. PhaseRoll

      PhaseRoll New Member

      Joined:
      Oct 29, 2012
      Messages:
      48
      Likes Received:
      0
      Trophy Points:
      0
      Wow ! I literally wasnt expecting you to do the work, I thought people would either ignore me or just give me advices on how to tweak the txt file

      I would try to test it out as soon as I can probably both in dungeons and BGs

      Thanks, I appreciate it
       
    17. Ramakandra

      Ramakandra New Member

      Joined:
      Oct 18, 2012
      Messages:
      49
      Likes Received:
      1
      Trophy Points:
      0
      I tried that but still it wont recognize the number of stacks, the full log and my CC .txt file is attached because is different to yours, (i took the rotation from Enhancement Shaman PvE DPS Rotation and Cooldowns (MoP 5.0.5)) .
      I will keep trying to get debug it.
      Thanks!

      Edit:
      It seems this makes it work:
      Code:
      Lightning Bolt
      	Me.HasAura("Maelstrom") = 1
      	Me.StackCount("Maelstrom Weapon") > 4
      
      The log says:
      Code:
      [14:40:15.114 D] [FTW] 11:40:15 +++ Maelstrom - 0 stacks, 29.9 seconds remaining
      [14:40:15.115 D] [FTW] 11:40:15 ----- Unleashed Fury
      [14:40:15.257 D] [FTW] 11:40:15 -------------------- FTW.Combat (112) Type: None, Loc: <0, 0, 0>
      [14:40:15.371 D] [FTW] 11:40:15 -------------------- FTW.Combat (114) Type: None, Loc: <0, 0, 0>
      [14:40:15.653 D] [FTW] 11:40:15 -------------------- FTW.Combat (113) Type: None, Loc: <0, 0, 0>
      [14:40:15.823 D] [Cast] Lightning Bolt 403
      [14:40:15.824 D] [CGSpellBook::CastSpell] Override ID: 403, KnownIndex: 57
      [14:40:15.842 N] [FTW] 11:40:15     Target.Cast Lightning Bolt on Training Dummy 5742 health 100 dist 2.6 aggro 0 UnitNotInThreatTable (addscount 1)
      [14:40:15.842 D] [FTW] 11:40:15 106 Lightning Bolt
      [14:40:15.842 D] [FTW] 11:40:15 107     Me.HasAura('Maelstrom') = 1     1 = 1
      [14:40:15.842 D] [FTW] 11:40:15 108     Me.StackCount('Maelstrom Weapon') > 4     5 > 4
      [14:40:15.842 D] [FTW] 11:40:15         TRUE
      [14:40:15.842 D] [FTW] 11:40:15 -------------------- FTW.Combat (188) Type: None, Loc: <0, 0, 0>
      [14:40:16.127 D] [FTW] 11:40:16 -------------------- FTW.Combat (113) Type: None, Loc: <0, 0, 0>
      [14:40:16.233 D] [FTW] 11:40:16 -------------------- FTW.Combat (106) Type: None, Loc: <0, 0, 0>
      [14:40:16.330 D] [FTW] 11:40:16 ----- Maelstrom
      
       

      Attached Files:

      Last edited: Oct 31, 2012
    18. Nevaehstar

      Nevaehstar New Member

      Joined:
      Feb 20, 2012
      Messages:
      4
      Likes Received:
      0
      Trophy Points:
      0
      I tested out the warrior revision this morning. Victory Rush is working great now, but for some reason it's not casting combat buffs any more. It's also not casting battle shout for rage regeneration and keeps spamming whirlwind/cleave when it has no rage and adds.
       
    19. randomstraw

      randomstraw Community Developer

      Joined:
      Jul 17, 2012
      Messages:
      1,611
      Likes Received:
      10
      Trophy Points:
      38
      Kinda Hunter specific one, atleast the example

      Q: why does the bot stop my character for all and everything, while it could "do instant casts" while moving? I understand the bot stopping it's movement for casting a spell with casttime. I don't want my bot to fire 1 or 2 Arcane Shots. I want my bot to continue moving, facing while moving, strafing some and look more human all over the place.

      What info do you need to, if, implement such behavior? ;)
       
    20. izzad

      izzad New Member

      Joined:
      Oct 29, 2012
      Messages:
      17
      Likes Received:
      1
      Trophy Points:
      0
      Hi, im using this with my ret paladin while leveling.
      Thing is, its great but my paladin targets every aggresive mob within 10 yards or so and attacks them while they are not needed for my quest.
      Also, my paladin attacks ranged with ranged -> jugement and not walking over to the target...

      Is there also a way to let the bot ignore monsters that are not needed for a quest when hes on hes way turning in a quest? would make life much easier because he spents pretty alot of time killing monsters on hes way to new quests etc.

      this are my settings:
      --====================================================================
      @COMBAT
      --====================================================================
      Me.Message Paladin_Retribution last updated 10/10/2012.
      Me.ClipTime 50
      Me.Range 2.0

      -----------------------------------------------------------------------
      -- Break free first
      -----------------------------------------------------------------------
      Me.Cast Will of the Forsaken
      Me.IsIncapacitated = 1
      Me.Use Insignia of the Scourge
      Me.IsIncapacitated = 1
      Me.Cast Every Man for Himself
      Me.IsIncapacitated = 1

      Me.Cast Emancipate
      Me.IsIncapacitated = 1
      Me.Cast Hand of Freedom
      Me.IsIncapacitated = 1

      -----------------------------------------------------------------------
      -- Healing spells
      -----------------------------------------------------------------------
      --Healer.CastOnce Sacred Shield
      -- Heal.Health < 100
      Tank.Cast Lay on Hands
      Me.Health < 40
      Me.UseHealthPotion
      Me.Health < 40
      Me.Cast Lifeblood
      Me.Health < 50
      Tank.Cast Flash of Light
      Tank.Health < 60
      Healer.Cast Hand of Protection
      Healer.Health < 50
      Me.Cast Divine Shield
      Me.Health < 60
      --Tank.Cast Eternal Flame
      -- Tank.Health < 70
      -- Me.HolyPower >= 1
      Me.Cast Divine Protection
      Me.Health < 80
      Me.Cast Word of Glory
      Me.HolyPower >= 1
      Me.Health < 80
      --Me.Cast Holy Prism
      -- Me.AvgHealth < 80
      --Heal.Cast Light's Hammer
      -- Target.AddsCount > 1
      --Heal.Cast Execution Sentence
      -- Heal.Health < 80
      Heal.Cast Flash of Light
      Heal.Health < 70
      Me.StackCount("Selfless Healer") >= 3

      -----------------------------------------------------------------------
      -- Rebirth
      -----------------------------------------------------------------------

      -----------------------------------------------------------------------
      -- Targeting
      -----------------------------------------------------------------------

      Me.FindBetterTarget

      -----------------------------------------------------------------------
      -- Ranged spells (cast while running)
      -----------------------------------------------------------------------
      Reckoning
      Target.Aggro < 2

      Judgment
      Target.Distance > 25
      --Speed of Light
      -- Target.Distance > 25


      -----------------------------------------------------------------------
      -- Movement
      -----------------------------------------------------------------------
      Me.FollowTarget

      -----------------------------------------------------------------------
      -- AOE
      -----------------------------------------------------------------------
      Divine Storm
      Target.AddsCount > 3
      Hammer of the Righteous
      Target.AddsCount > 4
      --Holy Prism
      -- Target.AddsCount > 1
      --Light's Hammer
      -- Target.AddsCount > 1
      --Target.Cast Execution Sentence
      -- Target.AddsCount > 1

      -----------------------------------------------------------------------
      -- Pull more if possible
      -----------------------------------------------------------------------
      Me.PullMore Judgment
      Target.AddsCount < 0
      Me.Health >= 50
      Me.InParty = 0

      -----------------------------------------------------------------------
      -- Combat Debuffs
      -----------------------------------------------------------------------

      --Repentance
      -- Target.AddsCount > 1
      -- Target.IsIncapacitated = 0

      -----------------------------------------------------------------------
      -- Combat buffs
      -----------------------------------------------------------------------
      Me.Cast Seal of Truth
      Me.HasAura("Seal of Truth") = 0

      Me.Cast Inquisition
      Me.HasAura("Inquisition") = 0
      Me.HolyPower >= 3
      Me.Cast Inquisition
      Me.HasAura("Inquisition") = 0
      Me.HasAura("Divine Purpose") = 1

      Me.Cast Avenging Wrath

      Me.Cast Blessing of Kings
      Me.HasAura("Legacy of the Emperor") = 0
      Me.HasAura("Mark of the Wild") = 0
      Me.HasAura("Blessing of Kings") = 0
      Me.Cast Blessing of Might
      Me.HasAura("Blessing of Might") = 0
      Me.HasAura("Legacy of the Emperor") = 0
      Me.HasAura("Mark of the Wild") = 0
      Me.HasAura("Blessing of Kings") = 0

      Me.Cast Cleanse
      Me.IsDiseased = 1

      --Me.Cast Holy Avenger

      Me.Cast Devotion Aura

      -----------------------------------------------------------------------
      -- Runners
      -----------------------------------------------------------------------

      -----------------------------------------------------------------------
      -- Interrupts
      -----------------------------------------------------------------------
      Target.InterruptAny Arcane Torrent
      Target.InterruptAny Rebuke
      Target.ParalyzeAny Fist of Justice
      Target.ParalyzeAny Hammer of Justice

      -----------------------------------------------------------------------
      -- Freebies
      -----------------------------------------------------------------------

      -----------------------------------------------------------------------
      -- Normal attack rotation
      -----------------------------------------------------------------------
      Guardian of Ancient Kings
      Target.AddsCount > 3
      Guardian of Ancient Kings
      Target.IsElite = 1
      Inquisition
      Me.HasAura("Inquisition") = 0
      Templar's Verdict
      Me.HasAura("Inquisition") = 1
      Templar's Verdict
      Me.HasAura("Divine Purpose") = 1
      Hammer of Wrath
      Exorcism
      Crusader Strike
      Judgment

      Me.AutoAttack

      --====================================================================
      @PULL
      --====================================================================

      Judgment
      Exorcism

      Me.AutoAttack

      Me.FollowTarget

      --====================================================================
      @REST
      --====================================================================

      Me.Cast Flash of Light
      Me.Health < 70

      Me.Eat
      Me.Health < 50

      Me.FollowTarget
       

    Share This Page