I wouldn't really call this an update, or even a fix. Sure, the plugin is doing what its name suggest: swap pets, but it is swapping in pets that it shouldn't swap in at all. I have it marked as favorites only, and it will use something completely different such as two chickens and Mr. bigglesworth none of the pets I have marked as a favorite.
Thank you for the words of encouragement Classe, it really helps motivate me to continue updating things. I make extensive use of the favorites and ringers settings and have leveled every pet in the game to 25 using this plugin and Pokehbuddy (both the plugin and the bot base). BPS does exactly what I tell it to. If you are experiencing problems, you are either using some functionality I have never used that contains a bug or you have the plugin set up wrong. I am not inclined to help you with either. Good luck.
I apologise if you took it the wrong way, it wasn't my intention. However, you did call this an update and since the plugin was working as intented before the 6.02 patch and it is not working now I wouldn't call it an update. Don't get me wrong, I do appreciate the work you put into this but there seems to be some error with it as it is now. Regarding me using some functionality or having set up a faulty plugin, that couldn't be accurate since I know how to use pokehbuddy and battlepetswapper together. Now, if you do not want to help me, I don't really mind, since I can run pokehbuddy without it, but you should really be more open for constructive criticism, when posting something, that is all.
To begin with, thanks for the plugin, used it several times in the past without any problems and made a bigger break from Wow. So I would like to continue to level my pets and downloaded your plugin and your fix but I can't see your plugin when honorbuddy is running. Does somebody know what I should do? I have a new and clean version of honorbuddy, downloaded the plugin and replaced the old Plugin.cs in all folders with your fixed version. Would appreciate every kind of help and sorry for the bad english skills, hope you can read/understand it anyway. Thanks.
I've gone back and re-read your first post several times, and I am of the opinion I responded fairly. I certainly would not consider it 'constructive criticism' - it seemed more like someone complaining that their free gift was the wrong color. We may have to agree to disagree about that, but c'est la vie. I did state that I 'Updated the plugin to get it working again', which simply involved renaming a single function due to an HB change. Nothing functionally was changed in the plugin. With this change the plugin worked exactly as it did before for me. After seeing your post, I went ahead and starting changing settings in the plugin around until I was able to duplicate what you saw - favorites being ignored. After a quick look at the code, I'm not sure how it ever worked reliably. There were no changes to the WoW API I saw that would account for this changed behavior, so if it was working for you previously, you may have just been lucky. I've gone ahead and made a change to LoadFromJournal() which should actually pay attention to favorites. It did correct the issue in the one case where I was able to duplicate it. Attached is the full plugin: View attachment 149993
I have the same problem as Classe, but I can see the BPS problem from the log: [BPS] Populating pet journal... [BPS] Favourite pets journal count: 713 Apparently it thinks every pet I have is a favorite, which is not correct.
Now that's constructive criticism! Try the zip I just posted and see if that fixes it for you. Cheers
Invalid Attachment specified. If you followed a valid link, please notify the administrator. It looks like LE_PET_JOURNAL_FLAG_FAVORITES was renamed, but I can't find it in the api patch changes. edit: Found it. Patch 6.0.2/API changes - Wowpedia - Your wiki guide to the World of Warcraft LE_PET_JOURNAL_FLAG_FAVORITES was removed.
I just added code to query the pet itself to see if it was a favorite before adding it to the list (if favorites only is selected). This is the attachement, and it is working for me. Can you try again? https://www.thebuddyforum.com/attachment.php?attachmentid=149993
Nice catch on the API change, that never showed up on any search I made. It is odd though, as the flag still seems to be present. There are a couple of WoW addons I use that make use of it and they are still functioning correctly.
Sorry, same error for the download. I need to go to bed now, if the link doesn't work by tomorrow I'll pm you my email.
Again, I apologise. I shouldn't have been so eager to critize someone who's willing to put both time and effort into updating this plugin. I should also have provided the log, which someone already has mentioned was due to the fact that BattlePetSwapper recognized all pets as favorites, not just the one's I had put down. That was leading it to believe a chicken, and Mr. Bigglesworth was a favorite.
As far as I can see no longer works: all pets are considered favorites as a result. Has Blizzard changed / damaged the flag value? I've looked at the possibility to use manual selection, like with IsRare, but isFavorite value is not currently cached - need to add it into cache etc. Update: oh, I see the discussion of exactly the same problem on the previous page, sorry. Let me try a new version. Update2: Yes, thank you! It works ok now.
Okay, so after updating everything it is finally working! yay! However, It doesn't seem to want to swap pets. I am trying to basically just grind, for the 500 battle achievement. BPS just doesn't seem to be willing to swap pets when their health is low, or they are dead. Any idea what I am doing wrong? It recognizes that a pet is critically injured....but never swaps. View attachment 41280 2014-11-17 14.02.txt
I am also having the same issue Firedrake is, everything appears to work up to the point where one pet dies & it just sits there (I have to manually click the next pet for the battle to continue). I am using the battlepetswapper & pokenbuddy botbase.
exactly same issue over here... If you use [PLUGIN] Pokebuddy - Gotto kill em all! everything works fine...
