• Visit Rebornbuddy
  • [Plugin] TidyBags 3.0 Reloaded!

    Discussion in 'Leveling' started by LiquidAtoR, Sep 15, 2010.

    1. LiquidAtoR

      LiquidAtoR Community Developer

      Joined:
      Jan 15, 2010
      Messages:
      1,430
      Likes Received:
      52
      Trophy Points:
      48
      Added for a future release
       
    2. Proto

      Proto New Member

      Joined:
      Jan 8, 2012
      Messages:
      219
      Likes Received:
      6
      Trophy Points:
      0
      Yep LiquidAtoR sorry about the confusion there. It was only after I posted the code to tidy up fish, that I discovered the fishing daily requirements.

      You need to clean the fish.. that is in the process of cleaning/combining the fish stacks you get "fish eggs" needed to complete the fishing daily. And you only get those eggs when the daily quest is active in your quest log.

      So it's probably in everyone's best interest to NOT tidy up fish if you plan to sell uncleaned stacks of fish in the AH for players that need them for completion of their daily quests. Seems money can be made in selling cleaned and uncleaned fish stacks.

      That is why I hope you'll consider adding a configuration option to include or exclude item sets on the fly. Or your idea to poll the community is probably easier. But if it were up to me, I'd vote no on tidying up fish this expansion.
       
    3. Proto

      Proto New Member

      Joined:
      Jan 8, 2012
      Messages:
      219
      Likes Received:
      6
      Trophy Points:
      0
      Oh.. and thumbs up on adding 110610, // Raw Beast Hide Scraps @ 10

      Thanks! :)
       
    4. LiquidAtoR

      LiquidAtoR Community Developer

      Joined:
      Jan 15, 2010
      Messages:
      1,430
      Likes Received:
      52
      Trophy Points:
      48
      If I ever start playing again I might (Don't hold your breath over it), but for now it's not in my interest to rewrite a addon when I'm not using it or playing the game, hmm ;-)
      For now your writeup is embedded inside TidyBags, just deactivated.
      When you add it yourself and use SVN it should merge with your changes should you choose to do so ^_^
      As long as I don't rewrite or majorly change the code it should stay put.
       
      Last edited: Dec 4, 2014
    5. laria

      laria Well-Known Member

      Joined:
      Jan 15, 2010
      Messages:
      5,386
      Likes Received:
      36
      Trophy Points:
      48
      which item ids require a skill to use them and tidy them up by combining and opening?
      Is skill 1 of skinning required for all leather pieces?
       
    6. LiquidAtoR

      LiquidAtoR Community Developer

      Joined:
      Jan 15, 2010
      Messages:
      1,430
      Likes Received:
      52
      Trophy Points:
      48
      You would have to look at each tooltip on Wowhead and see if there's a skill level (or character level) required besides the skinning or leatherworking skill besides the amounts etc.
       
    7. laria

      laria Well-Known Member

      Joined:
      Jan 15, 2010
      Messages:
      5,386
      Likes Received:
      36
      Trophy Points:
      48
      I made a script out of my suggestion, not sure if it works, i couldn't try it yet.
      Would appreciate feedback
       

      Attached Files:

      Last edited: Dec 13, 2014
    8. LiquidAtoR

      LiquidAtoR Community Developer

      Joined:
      Jan 15, 2010
      Messages:
      1,430
      Likes Received:
      52
      Trophy Points:
      48
      You will need feedback from 3 different cases to be 100% sure it works

      1) A skinner with 10+ Raw Beast Hide Scraps in his bags.
      2) A skinner (best a level 1 character with level 1 skinning) with 10+ Raw Beast Hide Scraps in his bags.
      2) A non-skinner with 10+ Raw Beast Hide Scraps in his bags.
       
      Last edited: Dec 6, 2014
    9. hahnottoday

      hahnottoday New Member

      Joined:
      Nov 6, 2014
      Messages:
      6
      Likes Received:
      0
      Trophy Points:
      0
      Hello, Could you update this so that it opens pvp strongboxes in draenor. Please
       
    10. LiquidAtoR

      LiquidAtoR Community Developer

      Joined:
      Jan 15, 2010
      Messages:
      1,430
      Likes Received:
      52
      Trophy Points:
      48
    11. longgegame

      longgegame New Member

      Joined:
      Oct 25, 2012
      Messages:
      23
      Likes Received:
      0
      Trophy Points:
      1
      not work. I added all strongboxes IDs to useonone and sleep lists...

      Code:
       private HashSet<uint> _itemUseOnOne = new HashSet<uint>() {
      		    111598,
      			111599,
      			111600,
      			119330,
      			120354,
      			120355,
      			120356,
      			120353,
                  3352, // Ooze-covered Bag
                  6351, // Dented Crate
                  6352, // Waterlogged Crate
                  6353, // Small Chest
                  6356, // Battered Chest
                  .........
      
      Code:
       private HashSet<uint> _itemRequiresSleep = new HashSet<uint>() {
                  111598,
      			111599,
      			111600,
      			119330,
      			120354,
      			120355,
      			120356,
      			120353,
      			61387, // Hidden Stash
                  67495, // Strange Bloated Stomach (Cataclysm Skinning)
                  67539, // 
                  .........
      
       
    12. damoiscrazy

      damoiscrazy New Member

      Joined:
      Dec 4, 2012
      Messages:
      43
      Likes Received:
      3
      Trophy Points:
      0
      Code:
      						} else if (_skinningItemUseOnTen.Contains(item.Entry)) { // stacks of 10
                                  if (item.StackCount >= 10) && (StyxWoW.Me.GetSkill(SkillLine.Skinning).CurrentValue >=1) ) {
                                      this.useItem(item);
      			    }
      
      Should be

      Code:
      						} else if (_skinningItemUseOnTen.Contains(item.Entry)) { // stacks of 10
                                  if (item.StackCount >= 10 && StyxWoW.Me.GetSkill(SkillLine.Skinning).CurrentValue >=1) {
                                      this.useItem(item);
      			    }
      
       
    13. laria

      laria Well-Known Member

      Joined:
      Jan 15, 2010
      Messages:
      5,386
      Likes Received:
      36
      Trophy Points:
      48
      With the help of Stormchasing , a small error in the file i uploaded was fixed and the code is now easier to read. New version is available in my original post.
       
    14. eXtOphius

      eXtOphius Member

      Joined:
      Jan 15, 2010
      Messages:
      219
      Likes Received:
      3
      Trophy Points:
      18
      For whatever reason, I have absolutely no luck with getting this version of the Plugin to work properly. I'll provide a logs and describe the exact problems if you'd like, not sure if anyone is really keeping this product up to date anymore (I know LiquidAtoR is busy).

      Cheers,
      XtO
       
    15. laria

      laria Well-Known Member

      Joined:
      Jan 15, 2010
      Messages:
      5,386
      Likes Received:
      36
      Trophy Points:
      48
      Does it even show up in the plugins menu? The first few people downloaded a file with compile errors.
       
    16. eXtOphius

      eXtOphius Member

      Joined:
      Jan 15, 2010
      Messages:
      219
      Likes Received:
      3
      Trophy Points:
      18
      It's not a compiling error, it shows up just fine. It just doesn't seem to work for me. I am still farming in MoP for materials, and Sha-Touched Leather and Mote of Harmony do not combine for me.
       
    17. laria

      laria Well-Known Member

      Joined:
      Jan 15, 2010
      Messages:
      5,386
      Likes Received:
      36
      Trophy Points:
      48
      log might be nice, for me it opens the winter veil gifts just fine
       
    18. LiquidAtoR

      LiquidAtoR Community Developer

      Joined:
      Jan 15, 2010
      Messages:
      1,430
      Likes Received:
      52
      Trophy Points:
      48
      It's not that I'm too busy, but I'm simply not playing anymore (already for months now).
      As it stands I might return to the game end summer - autumn or somewhere around that (for now let's say 60% chance I will return).
      We'll see as time passes :)

      Meanwhile I will keep an eye out on this topic every now and then.
       
    19. laria

      laria Well-Known Member

      Joined:
      Jan 15, 2010
      Messages:
      5,386
      Likes Received:
      36
      Trophy Points:
      48
      So here is a new version, which includes winterveil presents and other new items as well as a few debug messages to help us figure out why the leather combining doesn't work.
      If you have issues with Raw Beast Hide Scraps , please upload a logfile
       

      Attached Files:

    20. mussakka

      mussakka Member

      Joined:
      Dec 5, 2011
      Messages:
      63
      Likes Received:
      1
      Trophy Points:
      8

    Share This Page