[Plugin] CombatHelper - Targeting, pulling, RaF and stability fixes

CombatHelper v4.2.2

CombatHelper enhances target filtering, fixes combat issues and assists group members. Stuck handling features are now in StuckHelper plugin.

Features: (Designed for Honorbuddy 2.0.0.4317)
* - Improves target/loot filtering (integrates with CC)
* - Fixes stuck in combat and pet aggro bugs
* - Engages targets PvE and PvP (separate logic)
* - Ignores crowd-controlled targets in Battlegrounds
* - Follows leader and assists party/raid members
* - Auto attack for classes/specs that use it

Installation:
1. Download CombatHelper.cs to your Plugins folder.
2. Modify parameters (optional - see Configuration)
3. Click "Recompile All" under Plugins tab in Honorbuddy.
4. Select "CombatHelper" and check the "Enabled" checkbox.

For RaF botting (i.e. party/raid), on all followers enable FollowLeader in the configurations, load the attached Blank.xml profile, and run Combat/Heal Bot or Grind bot. Enable the plugin enabled on all toons. Alternately, use bot of your choice for leader with LeaderPlugin enabled, and run PartyBot on all followers (recommended). Another option is to try Multibox Suite by tjhasty.

Configuration:
1. Open CombatHelper.cs in your Plugins folder using any text editor (Notepad will do).
2. Edit configurations on lines 45+ (see code snippet below)
3. Save the file and click "Recompile All" in the Plugins tab.
4. Select "CombatHelper" and make sure it is enabled.

Code:

// User configurations
PullSpell = "None"; // Name of pull spell (leave unset to let CC pull)
MaxTargetDistance = 40; // Max distance to target nearby units
MaxAssistDistance = 75; // Max distance to assist nearby units
MaxLootDistance = 45; // Max distance to move to nearby lootable units
StuckInCombatTimeout = 10; // Seconds to wait out combat before pulling closest mob
FollowLeader = false; // Follow party/raid leader (or RaF leader if set)
FollowDistance = UseAutoAttack() ? 15 : 25; // Distance before moving to leader (RaF only)
MaxLevelsAbove = 3; // Don't pull mobs more than this many levels above me
MaxLevelsBelow = 5; // Don't pull mobs more than this many levels below me
LootLowLevelMobs = false; // Loot mobs more than MaxLevelsBelow levels than me
MaxHealthRatio = 2.5; // Don't pull mobs with more than this times my max health
MinHealthRatio = 0.1; // Don't pull mobs with less than this fraction of my health
IgnoreElites = true; // Enable to ignore elite mobs
IgnoreFlyers = true; // Enable to ignore flying mobs
MaxUnits = 25; // Max nearest units to inspect
FilterOnly = false; // Enable this setting to disable pull/assist feature
PullTargets = false; // Pull targets that are in range (disable to assist only)
PullTargetsPvP = true; // Pull targets while in battlegrounds
ClearTargets = false; // Clear targets that run out of range/LoS

Debugging: (test targeting logic)
1. Select CombatHelper in the Plugins tab.
2. Target any unit in-game.
3. Click "Unit Check" button.
4. Read log messages.

Known Issues:
- Overrides factions and min/max target levels set in a profile (in many cases this is a good thing)

Please post any bugs, suggestions or feedback.

 

/reserved

 

Nice work will test when i get a chance

 

Okay first of all good job on making this plugin. The problem that I was having before WITHOUT this plugin was that my character would just stand around forever not attacking any mobs when in combat. With this plugin my character will slowly (but surely) move towards a target and will EVENTUALLY get aggro on a mob. Obviously this plugin is made to get INITIAL aggro so it works perfectly, but for a profile like Kicks which levels on the elementals in Hyjal which are ALREADY under attack it works only half as well. Still, im not complianing as it is x10101991010119 better than the character just standing around for literally hours. So again, great work on this plugin.

 

A small problem, this plugin messes up the kill count. It adds kills to the kill count for things other people around me kill.

 

Updated for Honorbuddy 2.0.0.3740. See original post.

 

Hey lofi, I tried sending you a PM but I don't think it went through.

First of all, nice work this is really a great plugin! I do have a small request if you have some free time. The RAF bot is extremely buggy right now and I think a lot of people could benefit from a plugin like this that also checks other party members for aggro.

ie.
1. Checks if any party members have aggro
2. If aggro check is true, party leader then targets and attacks the aggro'ing mob

Combined with your other targeting enhancements, this could really be an awesome tool for RAF. Thanks in advance.

 

Updated v2.2 with support for:
RaF - Combat Assist
Combat/Heal Bot [1.0.0]
Instancebuddy (untested)

 

Skinning is a bit bugged, it starts skinning after looting and during half of the skinning process it runs away and attacks the next mob, NOT coming back. This however doesn't happen every time.
Sometimes it also says "I can't tell if we looted, blacklisting it just to be safe."

This is online happening since im using your plugin but its really nice so i would love to see this fixed.

(Using it with Grind bot, Shadowstrike CC)

Edit: Changed 2 things, never coded a plugin so this is just a try to fix it, but worked perfectly for me.
Sometimes the "I can't tell if we looted, blacklisting it just to be safe." problem is still occuring.
(changed version to 2.2.1)

Code:

if (BotPoi.Current.Type == PoiType.Loot)
    return; // don't interrupt looting

// Changed to

if (BotPoi.Current.Type == PoiType.Loot || BotPoi.Current.Type == PoiType.Skin)
    return; // don't interrupt looting

Code:

if (unit.Lootable && BotPoi.Current.Type != PoiType.Kill)
{
   break; // don't interrupt looting
}

// Changed to

if ((unit.Lootable || BotPoi.Current.Type == PoiType.Skin) && BotPoi.Current.Type != PoiType.Kill)
    break; // don't interrupt looting or skinning

Btw.: +rep would be nice

 

Thanks for the feedback! I hadn't tested it with any skinners before. I'm pretty sure you only need the first fix (and not the second edit - although it can't really hurt anything). Great job on figuring out how to edit the plugin. If you don't have it already I recommend you install Visual Studio and reference the latest Honorbuddy DLLs. This makes development a lot easier. I am having great results with this plugin running in Mixed mode farming Embersilk cloth at Circle of Cinders in Mount Hyjal (using a private profile - although there is a public one for exact same spot). This is an area where NPCs are fighting and you are often in combat even when you don't have a target. I would be interested to hear how this works with Instancebuddy as I have included RaF logic for both leader and follower.

 

Seems to be melee only? My mage would keep interrupting his casts by stepping closer.. and attacks with his autoattack

 

targeting is faster, BUT, the annoying problem with hunter and pet is not solve
bot still send pet to attack target not in range, and char just stand up and don't move, and just command the pet to attack all targets not in ranger untill 1 target enter in hunter range

 

I was testing the old version on my lock last night and it worked really well, it was just the fact it keps sneaking forward into melee range but only at certain times, the targeting feels really fluent though. I will test your new version when i get home.

 

it's a problem with all CC, i have posted this problem since a buy HB, the first cc i tried was Fpsware, and after i switch to simple shot, wich is the best cc for hunter in BG, as i am using HB only in BG

 

Using my warlock with the skiWarlock CC and this plugin enabled, I notice my toon will run up to try and auto attack, but will quite often run past the mob, turn around, run past the mob again, and repeat that process for quite awhile. Perhaps add a check for if the player is a caster, do not auto attack and instead just target and cast?

 

Added pull spell and updates internal target list (thanks nokdu). Tweaked for Honorbuddy 2.0.0.3895. See original post.

 

Well I like the plugin but it makes using AB take so much more time as it wants to kill everything around it at all times. This is a pain as for most of the dig sites the mobs are so far below my char's level that they only aggro if I happen to run through them.

If there was a way you could detect which bot was running, and disable the pull code while running AB (so it only activates if something attacks first) that would be great.

 

Thanks for the feedback. I will update the Plugin to not pull low-level mobs, and give it a quick test with AB when I get home.

 

That's certainly another way to do that bit of logic (since I saw you had "don't pull high level mobs" code in there). The only issue I can think of is if someone is *trying* to farm low level mobs (like going for the Parrot pet, or skilling up skinning from scratch, etc). Would that mean that the new code would overwrite the ability for the grind profile to do that?

 

I added max levels lower and set default to 5. I am running ArchaeologyBuddy with no issues now. Parameters 'MaxLevelsAbove' and 'MaxLevelsBelow' can be adjusted for your farming needs =). Updated original post with latest release.