• Visit Rebornbuddy

    • Singular - A community driven All-In-One CC - It Just Plain Works - (Pt. 2)

    Discussion in 'Archives' started by Xanathos, Apr 19, 2011.

    Page 45 of 82
    1. Fibonacci

      Fibonacci New Member

      Joined:
      Sep 25, 2011
      Messages:
      71
      Likes Received:
      0
      Trophy Points:
      0
      So, this CC ist using the Singular Bot automatically? Or do I have to change/set something for Retribution-Paladins?
      And what's the current Rotation for them? Is it possible to change it? Oh, just realized: How can I change Blessing of Kings into Blessing of Might? (Maybe it's just when I'm inside of a BG, I don' know)

      Sorry for those simple questions, but I'm using Singular the first time.
       
      Fibonacci, Dec 11, 2011
      #881
    2. Apoc

      Apoc Moderator Staff Member Moderator

      Joined:
      Jan 16, 2010
      Messages:
      2,790
      Likes Received:
      94
      Trophy Points:
      48
      Applied all the changes submitted in the last few days. Thanks to those of you who have been submitting. (Hard to keep track, and check all these changes!)

      @Nuok; please make sure you check your code before submitting. It would not compile by default. (Simple fix, but still, check your stuff)

      @Benkoren; I'm glad you're doing so much work on stuff. However, do keep in mind this CC needs to work from 1-85 (and end-game). I realize a lot of stuff is pretty much the same the whole way through, we do need to make sure things aren't shitty for low level players.

      I also added a fix for rogues failing miserably trying to pull flying targets. It should now throw/shoot. (Untested, but logically, it should work fine.)
       
      Last edited: Dec 11, 2011
      Apoc, Dec 11, 2011
      #882
    3. benkoren

      benkoren New Member

      Joined:
      Jan 18, 2011
      Messages:
      356
      Likes Received:
      28
      Trophy Points:
      0
      Is this why the MM hunter changes were reverted in rev450? If so I'll go back through it to make sure it'll work for lower levels better (including putting concussive shot back in while soloing). I had kept leveling/soloing in mind when writing the DK code, but not the hunter - I'll make sure the leveling/soloing works well in the future.
       
      benkoren, Dec 11, 2011
      #883
    4. Nuok

      Nuok Community Developer

      Joined:
      Jan 15, 2010
      Messages:
      975
      Likes Received:
      28
      Trophy Points:
      28
      Sorry about that did some last minute changes before i went to work on my mac and hoped it would compile
       
      Nuok, Dec 11, 2011
      #884
    5. Ruinit

      Ruinit Member

      Joined:
      Nov 1, 2010
      Messages:
      992
      Likes Received:
      4
      Trophy Points:
      18
      Just my opinion but 2 things need to be added to hunter cc's.


      Code:
      Spell.Buff("Hunter's Mark", ret => StyxWoW.Me.CurrentTarget.Elite),
// AoE
Spell.Cast("Multi-Shot", ret => Clusters.GetClusterCount(StyxWoW.Me.CurrentTarget, Unit.NearbyUnfriendlyUnits, ClusterType.Radius, 8) >= 3),
      If you don't it just spams Hunters mark on low level targets when you switch and it does no aoe at all :(

      I posted this a while back.
       
      Ruinit, Dec 11, 2011
      #885
    6. raphus

      raphus Administrator Staff Member Moderator Buddy Core Dev

      Joined:
      Jun 17, 2010
      Messages:
      2,094
      Likes Received:
      492
      Trophy Points:
      83
      Latest commit should fix most common issues with Singular v2.

      There has been lots of changes for healers and lots of other rearrangenements of behavior for almost all classes.
       
      raphus, Dec 11, 2011
      #886
    7. benkoren

      benkoren New Member

      Joined:
      Jan 18, 2011
      Messages:
      356
      Likes Received:
      28
      Trophy Points:
      0
      What was the reason that the MM Hunter changes I posted got reverted (rev450, I think)? I'd be happy to make the appropriate changes and testing - just gotta know what was wrong with what I submitted. In the version that you reverted to as of rev452 still has the nasty bug I mentioned where calling StyxWoW.Me.Auras["Ready, Set, Aim..."].StackCount throws an exception. Here's the post with the latest MM code I had posted: http://www.thebuddyforum.com/honorb...cc-just-plain-works-pt-2-a-22.html#post406789

      - Ben
       
      benkoren, Dec 11, 2011
      #887
    8. raphus

      raphus Administrator Staff Member Moderator Buddy Core Dev

      Joined:
      Jun 17, 2010
      Messages:
      2,094
      Likes Received:
      492
      Trophy Points:
      83
      I haven't reverted anything. Just added a Me.HasAura("Ready, Set, Aim...") check there as a fix
       
      raphus, Dec 11, 2011
      #888
    9. Kickazz006

      Kickazz006 Well-Known Member Moderator

      Joined:
      Jan 15, 2010
      Messages:
      20,567
      Likes Received:
      302
      Trophy Points:
      83
      what about fixes for warriors (by default)?

      there are 2-3 'in the sky' quests that melee w/o ranged spells fail horribly at
       
      Kickazz006, Dec 11, 2011
      #889
    10. JeffKing1989

      JeffKing1989 New Member

      Joined:
      Feb 16, 2010
      Messages:
      87
      Likes Received:
      0
      Trophy Points:
      0
      How is the Mage CC? DPS wise... in raids/dungeons
       
      JeffKing1989, Dec 11, 2011
      #890
    11. totbx

      totbx New Member

      Joined:
      Jan 2, 2011
      Messages:
      77
      Likes Received:
      0
      Trophy Points:
      0
      Warlock soul harvest is broke. He casts it but then immediately proceeds to the next action.
       
      totbx, Dec 11, 2011
      #891
    12. benkoren

      benkoren New Member

      Joined:
      Jan 18, 2011
      Messages:
      356
      Likes Received:
      28
      Trophy Points:
      0
      It looks like Apoc reverted things in rev450, I'm guessing because the changes weren't friendly to hunters that were leveling up. I'm attaching another version where I've gone back and merged in the changes I made to make the dps much much better along with the changes to make the hunter's life much easier when solo'ing/leveling. This involved adding back in the pre-rev441 solo-oriented abilities (kill command, concussive shot) along with a check to make sure they're not in an instance.

      I've also moved the Hunter's Mark down to be a single-target-only ability as well as a check to make sure it's a boss. Bosses will still get Marked for Death via Chimera Shot, really the only reason this needs to be here is if a boss gets chain pulled while Chimera is on cooldown. This change should improve both soloing and AoE quite a bit, as Ruinit mentioned.

      The code attached should be friendly for hunters anywhere from low level up to high end raiding.

      See attachment.

      - Ben
       

      Attached Files:

      Last edited: Dec 11, 2011
      benkoren, Dec 11, 2011
      #892
    13. benkoren

      benkoren New Member

      Joined:
      Jan 18, 2011
      Messages:
      356
      Likes Received:
      28
      Trophy Points:
      0
      I think the solution to this will be the same exact code Apoc used to fix the rogues:

      I don't have a warrior handy to test this and post the full .cs file, but I'm sure Apoc plans on adding it soon.
       
      benkoren, Dec 11, 2011
      #893
    14. benkoren

      benkoren New Member

      Joined:
      Jan 18, 2011
      Messages:
      356
      Likes Received:
      28
      Trophy Points:
      0
      I've seen this behavior with Soul Harvest as well as with Create Healthstone and Health Funnel, definitely something to look into.
       
      benkoren, Dec 11, 2011
      #894
    15. nysos

      nysos Member

      Joined:
      Aug 3, 2010
      Messages:
      43
      Likes Received:
      0
      Trophy Points:
      6
      My level 58 priest just stands there til it dies while in combat.

      EDIT: Using the latest Revision 454...
       
      Last edited: Dec 12, 2011
      nysos, Dec 12, 2011
      #895
    16. dracoe

      dracoe Member

      Joined:
      Jan 15, 2010
      Messages:
      302
      Likes Received:
      3
      Trophy Points:
      18
      I download Singular from the SVN, now HB says this:

       
      dracoe, Dec 12, 2011
      #896
    17. Kickazz006

      Kickazz006 Well-Known Member Moderator

      Joined:
      Jan 15, 2010
      Messages:
      20,567
      Likes Received:
      302
      Trophy Points:
      83
      delete the hb-shipped singular
       
      Kickazz006, Dec 12, 2011
      #897
    18. Ruinit

      Ruinit Member

      Joined:
      Nov 1, 2010
      Messages:
      992
      Likes Received:
      4
      Trophy Points:
      18
      Survival Hunter uses "Concussive Shot" and "Kill Command" ? And does not use multi-shot at all? It's a huge dps drop. My edited version does 5k dps more than stock version. But I am no coder so I can't make the chages needed so it can get posted.
       
      Ruinit, Dec 12, 2011
      #898
    19. dracoe

      dracoe Member

      Joined:
      Jan 15, 2010
      Messages:
      302
      Likes Received:
      3
      Trophy Points:
      18
      How you tell singular to use bear only, forget the cat.
       
      dracoe, Dec 12, 2011
      #899
    20. gilette

      gilette New Member

      Joined:
      Aug 31, 2011
      Messages:
      160
      Likes Received:
      1
      Trophy Points:
      0
      "We do not support past versions of HB! "
      Well, you dont seem to support to current version of HB either.. 4 months and moonkin cc is still broken, at least they do not seem to initiate combat on quest and grind profiles for skinning.
       
      Last edited: Dec 12, 2011
      gilette, Dec 12, 2011
      #900
    Page 45 of 82

    Share This Page