• Visit Rebornbuddy
  • Job's Legendary Rule set

    Discussion in 'Plugins' started by Job2k9, May 9, 2014.

    1. xxfearxx

      xxfearxx New Member

      Joined:
      Apr 17, 2013
      Messages:
      176
      Likes Received:
      2
      Trophy Points:
      0
      well in the context i posted there it doesn't work, the bot seems to just keep the item regardless of what the macro returns, essentially ignoring the macro and it becoming a simple keep rule. cant find anything in any of the documentation for item rules that would cover this either =/
       
    2. arthurmaple

      arthurmaple Member

      Joined:
      Aug 12, 2014
      Messages:
      41
      Likes Received:
      2
      Trophy Points:
      8

      THX,man

      BTW, where can i get ItemRules2.txt?
       
      Last edited: Sep 27, 2014
    3. xxfearxx

      xxfearxx New Member

      Joined:
      Apr 17, 2013
      Messages:
      176
      Likes Received:
      2
      Trophy Points:
      0
      should be in \Plugins\Trinity\ItemRules
       
    4. Bertrand

      Bertrand Active Member

      Joined:
      Aug 8, 2012
      Messages:
      1,249
      Likes Received:
      9
      Trophy Points:
      38
      Ok so we need to manually add keep or trash tags after each line of legendary items as to make our own rules in the post 2.1 .zip file ? Can someone upload already edited legendary.dis file with proper keep/trash tags for each item ?

      edit: well for now i just added the new 2.1 legendary list to the old legendary item rules that are outdated, how wrong can it go ? :D
       
      Last edited: Sep 28, 2014
    5. buddydemon

      buddydemon New Member

      Joined:
      Apr 14, 2014
      Messages:
      27
      Likes Received:
      1
      Trophy Points:
      0
      Hi, this is missing: (season quiver)

      [QUALITY] == "Legendary" && [NAME] == "Meticulous Bolts"
       
      Last edited: Sep 28, 2014
      Job2k9 likes this.
    6. Bertrand

      Bertrand Active Member

      Joined:
      Aug 8, 2012
      Messages:
      1,249
      Likes Received:
      9
      Trophy Points:
      38
      btw if an item is missing, is it stashed by default ? If it is no big deal then i guess...
       
    7. BestWarOCE

      BestWarOCE Member

      Joined:
      Jun 23, 2014
      Messages:
      289
      Likes Received:
      10
      Trophy Points:
      18
      Looking forward to you adding a monk list :) Thanks for all your hard work!
       
    8. Job2k9

      Job2k9 New Member

      Joined:
      Feb 11, 2010
      Messages:
      842
      Likes Received:
      3
      Trophy Points:
      0
      There is no overall trash rule, so basically only things specifically with [TRASH] get tossed. I don't use global trash rules for that specific reason (they add items, change names etc).
       
    9. Job2k9

      Job2k9 New Member

      Joined:
      Feb 11, 2010
      Messages:
      842
      Likes Received:
      3
      Trophy Points:
      0
      Uploaded the rules I've used personally for a few DH and one Monk.
       
    10. DavidKDean

      DavidKDean Member

      Joined:
      Jun 15, 2012
      Messages:
      217
      Likes Received:
      1
      Trophy Points:
      18
      Gonna give this a shot right now man.
       
    11. buddydemon

      buddydemon New Member

      Joined:
      Apr 14, 2014
      Messages:
      27
      Likes Received:
      1
      Trophy Points:
      0
      the seasonal templar follower token is a negative number:

      //Hillenbrand’s Training Sword
      [QUALITY] == "Legendary" && [ITEMID] == "-765770607"
       
    12. omfgrjj

      omfgrjj Member

      Joined:
      Aug 3, 2014
      Messages:
      50
      Likes Received:
      0
      Trophy Points:
      6
      Thank you dude. I have been waited for this for like a century.
      As I am looking for a loot rule that is for DH, this loot rule reduce much of my time to do it myself.
      really thanks.
      Is there any paypal link provided for donation?
       
    13. Job2k9

      Job2k9 New Member

      Joined:
      Feb 11, 2010
      Messages:
      842
      Likes Received:
      3
      Trophy Points:
      0
      Oh! I never expected any sort of donations, but hey if you feel these rules have helped you out and can afford to donate then sure, I'll make a button on the main post.
       
    14. barbarian6

      barbarian6 New Member

      Joined:
      Nov 28, 2012
      Messages:
      209
      Likes Received:
      0
      Trophy Points:
      0
      Job2k9

      I think You have mistake in Your rules.
      shouldn't it be ?
      also in
      are You sure 1x = is good? or maybe it should be?
       
      Last edited: Oct 2, 2014
    15. Job2k9

      Job2k9 New Member

      Joined:
      Feb 11, 2010
      Messages:
      842
      Likes Received:
      3
      Trophy Points:
      0
      Good call, yeah the ring macro was missing a .dual, I was keeping pretty much every ring w/ CD which was a mistake but not anything serious. I've since changed my bracer rules to:
      Code:
      [QUALITY] == "Legendary" && [NAME] == "Ancient Parthan Defenders" # [CRIT%] < 6 || [SKILLDMG%] < 20 -> [TRASH]
      Going to start using rules like these where it'll trash if stats are under, this way I don't need an additional TRASH line for the same item. Also I appreciate any corrections! I'll have to get notepad+ again to spot any formatting errors I may make.
       
    16. barbarian6

      barbarian6 New Member

      Joined:
      Nov 28, 2012
      Messages:
      209
      Likes Received:
      0
      Trophy Points:
      0
      This is my file which is Your DH+monk version tuned a bit and adapted to Barbarian. (if You could have a quick look and say if there is no huge mistakes would be great)

      I didn't like Your Bracer/ Ring/Amulet thinking, where You had general trash rule, cause in case of some change or new items etc...(or other unpredicted thing, there was possibility of trashing good item).

      Instead I've used Your thinking and did it like You wrote above...

      would rules like this work correctly?

      trashing this helm if it doesn't have socket or cc
      trashing this ring if it doesn't have at least 1 stat from macro?
      same as Yours above but with maxstat?
      [SKILLDMG%] is 100% working for every element (fire, physical, cold, lighting?)

      1 tip, since there is no CDR (cooldown reduction) stat in itemrules...You might want to change Your ring rules by "-1"...
      at least for barb where CDR is desired there is possible roll:
      mainstat, cdr, loh, cc....
      in this case and Your rule
      [QUALITY] == "Legendary" && [NAME] == "Leoric's Signet" # [@GOODRING] > 1 -> [KEEP]
      such item would get trashed

      after enchanting could be
      mainstat, cdr, socket, cc ....which is BiS for some builds...

      EDIT: FIXED MISTAKE POINTED BY JOB2K9 below.
       

      Attached Files:

      Last edited: Oct 4, 2014
    17. Job2k9

      Job2k9 New Member

      Joined:
      Feb 11, 2010
      Messages:
      842
      Likes Received:
      3
      Trophy Points:
      0
      the bracers line you have will trash if it has a max stat and crit is less than 6, or if it has a max stat and skill dmg is less than 18. If it has no max stat it will keep them, which seems odd.

      [SKILLDMG%] I don't think detects phyical. CDR should be working [CDRED%].
       
      Last edited: Oct 2, 2014
    18. Alewyne

      Alewyne New Member

      Joined:
      Aug 11, 2013
      Messages:
      76
      Likes Received:
      0
      Trophy Points:
      0
      For me it still picks yellows up also and stashes them , though i disabled in trinity :S Any hints?
       
    19. barbarian6

      barbarian6 New Member

      Joined:
      Nov 28, 2012
      Messages:
      209
      Likes Received:
      0
      Trophy Points:
      0
      stupid mistake, I've fixed it and uploaded previous file.
       
    20. evilking

      evilking Member

      Joined:
      Jun 26, 2013
      Messages:
      448
      Likes Received:
      4
      Trophy Points:
      18
      Hi, could someone explains what does the .dual in the macro ? ty
       

    Share This Page