• Visit Rebornbuddy
  • [Plugin] Loot Artifact Angler Trait Barrels

    Discussion in 'Uncataloged' started by speshulk926, Oct 10, 2016.

    1. speshulk926

      speshulk926 Community Developer

      Joined:
      Dec 8, 2014
      Messages:
      911
      Likes Received:
      17
      Trophy Points:
      18
      I was banned and am no longer supporting this as I am no longer playing. Feel free to use however you see fit.

      It has been widely asked on the site to try and loot these barrels. Instead of adding this to the Keep Lure Active plugin, I decided to just make a separate plugin for it.

      First, if you are curious what the Artifact Fishing weapon is, check this out:
      The Legion Fishing Artifact, Underlight Angler - Guides - Wowhead

      Second, if you want to get this pole, my other plugin can help you some of the way:
      https://www.thebuddyforum.com/honor...ctive-legion-ancient-fishing-pole-helper.html

      Third, here's what the plugin does:
      [​IMG]

      General Info
      Loot Barrels
      Each type of fish has a trait on the Underlight Angler that allows when you cast to fish up "a whole pool in 1 cast". Usually this means 5 fish and sometimes a rare lure (if you are using rare lure finder).

      The plugin finds a barrel around you and then adds it to the current bot POI (point of interest). I cannot set a priority on this point to the best of my knowledge.

      It will skip some. There's nothing I can do about it. It will get most of them though. Before making a post saying it skipped one, please look around and see if there are more pools nearby. If there are, it will do those first and (if the barrel still is there) come back for the barrel. This is an issue with Fishing Buddy. When they get around to updating Fishing Buddy, this will likely all be added to it and this will no longer be needed.

      Keep Fishing Pole Equipped
      As I was testing this, I was getting frustrated that if I got in combat, Fishing Buddy would equip my weapons. I then got out of combat and Fishing Buddy didn't re-equip my pole. My character would then run through water, etc going really slow. This now looks to see if you have an artifact pole to equip, and if so, and not in combat, it will equip the pole at all times.

      Status of Each Barrel Type
      [table="width: 500, class: grid, align: left"]
      [tr]
      [td]Cursed Queenfish[/td]
      [td]Working[/td]
      [/tr]
      [tr]
      [td]Runescale Koi[/td]
      [td]Working[/td]
      [/tr]
      [tr]
      [td]Black Barracuda[/td]
      [td]Working[/td]
      [/tr]
      [tr]
      [td]Mossgill Perch[/td]
      [td]Working[/td]
      [/tr]
      [tr]
      [td]Highmountain Salmon[/td]
      [td]Working[/td]
      [/tr]
      [/table]

      [HR][/HR]

      Donate
      I do not create things for money. I love coding! However, it does take time, so if you feel like I have helped you in some way, a donation is always appreciated. I do not expect them and will not treat donators any different than non-donators.
      [Paypal]
       

      Attached Files:

      Last edited: Nov 12, 2016
    2. Meisterlampe22

      Meisterlampe22 New Member

      Joined:
      Oct 16, 2012
      Messages:
      18
      Likes Received:
      0
      Trophy Points:
      1
      Hello,

      first of it is "working"

      BUT:
      I have strange behaviors with this Plugin.
      When an Barrel spawns, the Plugin sees it but runs away. After a few seconds its comming back to loot the barrel.

      Any Idea why?
       
    3. speshulk926

      speshulk926 Community Developer

      Joined:
      Dec 8, 2014
      Messages:
      911
      Likes Received:
      17
      Trophy Points:
      18
      My guess is when you are on top of the water, maybe HB3 is having issues mapping to it? This is the full movement code:

      Code:
      if (_currentBarrel.Distance > 3)
      {
          await CommonCoroutines.MoveTo(_currentBarrel.Location);
      }
      else
      {
          await CommonCoroutines.StopMoving();
          _currentBarrel.Interact();
      }
      
      
      You can see, there's not much to it. ".MoveTo" is an HB3 command, so it is built in and not custom. I have little control over the path it takes when it goes there.
       
    4. speshulk926

      speshulk926 Community Developer

      Joined:
      Dec 8, 2014
      Messages:
      911
      Likes Received:
      17
      Trophy Points:
      18
      I received a report that the Highmountain Salmon were not being caught correctly. I will target that one as my next Barrel to catch if someone else doesn't give me the ID. If I have the ID, I can just grab it.

       
    5. speshulk926

      speshulk926 Community Developer

      Joined:
      Dec 8, 2014
      Messages:
      911
      Likes Received:
      17
      Trophy Points:
      18
      New Update [v1.1]
      - Added IDs for all of the Barrels.

      It *should* pick them up now. Please let me know if one does not work for you.
       
    6. ewqqweewq

      ewqqweewq New Member

      Joined:
      Oct 4, 2016
      Messages:
      3
      Likes Received:
      0
      Trophy Points:
      0
      still skips runescale's barrels
       
    7. speshulk926

      speshulk926 Community Developer

      Joined:
      Dec 8, 2014
      Messages:
      911
      Likes Received:
      17
      Trophy Points:
      18
      I'll look at it tonight. Thanks for the report.
       
    8. GMJohnny

      GMJohnny New Member

      Joined:
      Nov 19, 2014
      Messages:
      8
      Likes Received:
      0
      Trophy Points:
      0
      Is something I am doing wrong? The bot recognizes the mossgirl perch barrel, says it will loot it, then the bot runs off on path again.
       
    9. speshulk926

      speshulk926 Community Developer

      Joined:
      Dec 8, 2014
      Messages:
      911
      Likes Received:
      17
      Trophy Points:
      18
      I've seen this a few times myself. I think I have another way of doing it, but need to find the time. Something weird with Fishing Buddy. I've seen it go back to the waypoint, then turn right back around, run back to the fishing barrel and then loot it. I'll see what I can do to keep it from doing that, but my knowledge of how FishingBuddy works is limited.
       
    10. speshulk926

      speshulk926 Community Developer

      Joined:
      Dec 8, 2014
      Messages:
      911
      Likes Received:
      17
      Trophy Points:
      18
      I have what I believe is a working version now. I am going to test out all pools though first and make sure they all work before I post it. I am also adding something to keep fishing pole equipped as well when not in combat.

      Edit: Tried out this version on a few different pools and I can't quite figure out why FishingBuddy doesn't loot. Best I can tell when the Barrel spawns, if there's another pool ~close~ to it (i'm not sure the distance), it seems to ignore the barrel and keep moving.

      You can equate this to a Grind profile or something. In a Grind profile, you kill 4-5 people that are in combat with you before you start to loot. In Fishing, if there's too many fishing nodes, it sees those as priority and not looting Barrels. I believe this needs to be fixed in Fishing Buddy, but I'm not familiar enough with FishingBuddy to say for certain.

      What I can say is that if there aren't nodes too close to each other, it appears to be working. It does look like it is going to still skip some, but not all. If it skips one, it is likely to come back to it (I've seen it do this). After I continue to test some more, I will post it.
       
      Last edited: Oct 15, 2016
    11. GMJohnny

      GMJohnny New Member

      Joined:
      Nov 19, 2014
      Messages:
      8
      Likes Received:
      0
      Trophy Points:
      0
      Interesting, if there is a pool nearby it does ignore it. Just like a grinding profile. I am not savy in programming, but is there a way to have a plugin that prioritizes loot over pulling more perhaps?
       
    12. thaone0523

      thaone0523 New Member

      Joined:
      Jul 25, 2011
      Messages:
      130
      Likes Received:
      0
      Trophy Points:
      0
      Can confirm the Koi Barrels are not getting looted. Hope you can get that working thanks for sharing this and taking your time to make it!
       
    13. speshulk926

      speshulk926 Community Developer

      Joined:
      Dec 8, 2014
      Messages:
      911
      Likes Received:
      17
      Trophy Points:
      18
      New Update: v1.2

      Also, I have personally tested every pool at least once. It did pick up a barrel from each type. It did skip them sometimes as noted above.
       
    14. pimpampum

      pimpampum Member

      Joined:
      Nov 29, 2012
      Messages:
      769
      Likes Received:
      21
      Trophy Points:
      18
      Thanks for the plugin, it's really useful.

      I'm having issues with latest update where it refuses to allow non-fishing artifact to get equipped when in combat, it reequips the underlight. I don't know if it can be done, but setting this plugin to only work when certain botbases are being used (fishingbuddy, professionbuddy) would be really helpful.
       
    15. speshulk926

      speshulk926 Community Developer

      Joined:
      Dec 8, 2014
      Messages:
      911
      Likes Received:
      17
      Trophy Points:
      18
      Oh, I see. Yeah, let me at the very least make that a setting. I had only used this under FishingBuddy before. I'll see if I can have something out today sometime to fix that.

      The reasoning for that is when not in combat, it equips the Angler to keep you swimming fast or something. It shouldn't do it in combat. It would do it if you were out of combat and then back in combat and your current routine doesn't equip best for you.
       
      Last edited: Oct 24, 2016
    16. whitefox

      whitefox Member

      Joined:
      Nov 29, 2012
      Messages:
      103
      Likes Received:
      3
      Trophy Points:
      18
      can this plugin open stuff from darkmoon fairy like the bloated threshers ? =)
       
    17. speshulk926

      speshulk926 Community Developer

      Joined:
      Dec 8, 2014
      Messages:
      911
      Likes Received:
      17
      Trophy Points:
      18
      All it does is attempt to loot barrels from the artifact fishing pole (Underlight Angler) trait. Not sure why you would think it would do anything else. Pretty clearly states.
       
    18. whitefox

      whitefox Member

      Joined:
      Nov 29, 2012
      Messages:
      103
      Likes Received:
      3
      Trophy Points:
      18
    19. speshulk926

      speshulk926 Community Developer

      Joined:
      Dec 8, 2014
      Messages:
      911
      Likes Received:
      17
      Trophy Points:
      18
      Sorry he lead you astray. Opening a container has nothing to do with using a fishing lure. You should try some of the already-existing container openers that exist.
       

    Share This Page