• Visit Rebornbuddy
  • [Release] Healing (Manual Targeting)

    Discussion in 'Buddy Wing Forum' started by SirSik, Apr 18, 2017.

    1. SirSik

      SirSik Member

      Joined:
      Jul 9, 2013
      Messages:
      173
      Likes Received:
      6
      Trophy Points:
      18
      sorry, i shouldn't be doing these releases without testing them....
      So to give you some more information: The logger.cs pretty much always comes up, it's just a warning.
      The Seer one has come up as for when it looks to "Spell.cs" on what to do when it's being told to cast Spell.Hot, is it has 5 arguments. When i just checked, next to force armour it states:

      Spell.HoT("Force Armor", 100, on => Me, 100, ret => !Me.CurrentTarget.HasDebuff("Force-imbalance")),

      As you can see, I've F***ed up and put in 6 arguments. That is trying to cast, force armour, if the target has 100% hp, on me, if the target has 100% hp, and as long as my current target doesn't have the debuff "Force-imbalance" (yes i've just realised i messed up twice)

      So mistake number 1. It's checking for HP% twice... remove the first instance of "100,"
      and the mistake i realised when i was writing this - It's looking to my TARGET for the debuff of force-imbalance when it should be looking to see if the debuff is on me.

      so removing the first mistake and fixing the other should make the working version look like this (i've also added an extra check into it which checks to make sure you're in combat, that way it doesn't keep bubbling you when you;re out of combat)

      Spell.HoT("Force Armor", on => Me, 100, ret => Me.InCombat && !Me.HasDebuff("Force-imbalance")),

      hope this gives you a better understanding of it all and i've (once again) updated the seer routine in this thread.

      Updated Seer routine :)
       
      Praline likes this.
    2. Praline

      Praline Member

      Joined:
      Aug 17, 2015
      Messages:
      149
      Likes Received:
      2
      Trophy Points:
      18
      Thank you so much for sharing your know how. I am enjoying learning with you. :)
       
    3. SirSik

      SirSik Member

      Joined:
      Jul 9, 2013
      Messages:
      173
      Likes Received:
      6
      Trophy Points:
      18
      that's ok :) i know more than one person wanted this fixing and i know it's not the simplest, cleanest editing etc etc... it works for now :p
      I'm back at work now for 4 days then on my week off after that i am going to try look for other ways to fix it with a fresh defaultcombat :) will see if i can actually get a new way for working out health percentage, i just need to learn to understand that api documentation that we have etc
       
    4. SirSik

      SirSik Member

      Joined:
      Jul 9, 2013
      Messages:
      173
      Likes Received:
      6
      Trophy Points:
      18
      OK, Holy shit... I've fixed it already........

      Ok... So, Praline, test this out for me.

      Reinstall the ORIGINAL defaultcombat in the routines folder.
      go into the Core folder and replace the text in targeting.cs with this and try that out. If you prefer that way to the manual targeting then i will continue to make improvements based on that method and redo this whole thread based on that.
       

      Attached Files:

      Last edited: Apr 21, 2017
      Praline likes this.
    5. Praline

      Praline Member

      Joined:
      Aug 17, 2015
      Messages:
      149
      Likes Received:
      2
      Trophy Points:
      18
      Holy moly! I am speechless!
      So Aevitas changes based on Pindleskin's suggestions did work. The only missing piece in the puzzle have been YOU all along to put it all together. :)
      It worked well. In PVE it was as good as it was in the old days, or maybe better. It was healing my comp when needed, and zapping mobs like a pro. Do you think it will help to change healthpercent to stathealth for the cleansing bit to work as well? That would be a dream come true to be able to use this in OPS again. OMG you sir need a MEDAL!!!!
       
      Last edited: Apr 21, 2017
    6. kurfer

      kurfer Member

      Joined:
      Dec 6, 2011
      Messages:
      206
      Likes Received:
      1
      Trophy Points:
      18
      So I added the spell.cs data in your original post and my operative still spams heals constantly. It's very random on who it selects; it's like an idiot is playing it. Refuses to self heal if I target myself and random will spam rotation on dudes with 100% health. It works semi OK with your auto file.

      Am I to understand I keep everything original except for spell.cs with the manual heal?
       
    7. kurfer

      kurfer Member

      Joined:
      Dec 6, 2011
      Messages:
      206
      Likes Received:
      1
      Trophy Points:
      18
      So it looks like this manual thing just spams abilities regardless of "health" in the order of your rotation and ignores all buff counts and other stuff.

      Yeah this is how you get kicked right the F out of your guild for being a trash tier healer! No thanks!
       
    8. Praline

      Praline Member

      Joined:
      Aug 17, 2015
      Messages:
      149
      Likes Received:
      2
      Trophy Points:
      18
      You can't read very well or follow instructions that was written very clearly, can you? Maybe best to delete your swtor folder and move on.
       
    9. SirSik

      SirSik Member

      Joined:
      Jul 9, 2013
      Messages:
      173
      Likes Received:
      6
      Trophy Points:
      18
      Thing is the Med Op routine is written quite differently to Corruption for example.
      The changes i made in spell.cs just turn off auto targeting...
      but when you have something in a rotation that looks like this:

      Spell.Cast("*Spell goes here*, ret => HealTarget.*blah blah*),

      It will still cast on HealTarget which it gets from Targeting.
      if you changed the spells to this then it will be ok

      Spell.Cast("*Spell goes here*, ret => Me.CurrentTarget),
       
    10. kurfer

      kurfer Member

      Joined:
      Dec 6, 2011
      Messages:
      206
      Likes Received:
      1
      Trophy Points:
      18
      I followed the instructions very clearly and have contributed with my limited knowledge of programming to have my changes to marauder routines make it in via an official update. Please don't white knight, white knights are very annoying.

      What I am saying still stands, worthy attempt but IF a spell is constantly spammed regardless of health values it's not going to be efficient. The instructions for the manual targeting state to replace the spell.cs only. In addition he provides sorc/sage healing rotations. I tried those on my respective healers and everything performs the same way. Randomly targets myself (no tank target lines present) and will just spam the rotation in an odd order regardless of health on my target.

      IF there is another step, it's not defined in the original thread.

      I understand how the rotations work, my current Marauder tweaks are beating top tier players in ranked warzones atm. It outperforms 3k+ rated players currently. I have not modified anything else that would warrant this odd behavior so I can only assume this is working as intended.

      I'm not worried about the health values as much as I am the additional variables in the equation.

      With the sorc/sage what I *THINK* is causing it to constantly target myself is that there is code that ensures I always have a bubble on myself. Part of that code also checks to ensure I don't have the "debuff" associated when the bubble wears off. IF my bubble drops, it tries to target myself and reapply but can't so it's constantly re-targetting myself as I try to target a player who's health is dropping ultimately letting them die.

      In the instance of the OP, you kinda need it to look at health. You want to maintain kolto probe on targets; you need the rotation to ensure you're maintaining 2 stacks of probe and reapplying 3-6 seconds before it drops. What I experience with the manual rotation fix is that it will spam probe over and over thus overlapping and wasting energy and not casting bigger heals when needed.
       
      Last edited: Apr 26, 2017

    Share This Page