• Visit Rebornbuddy
  • BenderCombat (WIP)

    Discussion in 'Archives' started by Bender69, Feb 27, 2016.

    1. Bender69

      Bender69 Community Developer

      Joined:
      Dec 31, 2015
      Messages:
      59
      Likes Received:
      0
      Trophy Points:
      0
      Hi,

      So I decided to work on my own combat routines, since I think DefaultCombat needs an overhaul. Feel free to help me create this, I tried to create the initial build based on DefaultCombat, and added the project.

      You can follow my work on github: https://github.com/Bender69/BenderCombat

      Currently it just works much better with some classes, added more hotkeys for charge/interrupt, but I will make it better, its a work in progress.

      There is many things I dont like, why would you need to create extra combat routines between empire and republic, when they work the same way, but with different ability names?

      Also this routines will be tweaked towards raiding, not grinding. Keep that in mind. DefaultCombat works best for normal grinding.

      BR, Bender69
       
      Last edited: Feb 27, 2016
    2. alltrueist

      alltrueist Active Member

      Joined:
      Dec 10, 2012
      Messages:
      1,424
      Likes Received:
      16
      Trophy Points:
      38
      What have you changed? It looks like DefaultCombat right now.
       
    3. Bender69

      Bender69 Community Developer

      Joined:
      Dec 31, 2015
      Messages:
      59
      Likes Received:
      0
      Trophy Points:
      0
      Combat routines are my own, most of them have been modified for dps, working on enabling/disabling interrupts/charge etc. range fix and more. As I said, its a WIP, just wanted to share. Problem is that DefaultCombat gets updated each time that there is a bot update, hence why I started working on my own routine, since DefaultCombat is broken for many classes. an example is scoundrel aoe is healing for one of the dps specs.
       
    4. bonbi870

      bonbi870 New Member

      Joined:
      Oct 16, 2014
      Messages:
      13
      Likes Received:
      0
      Trophy Points:
      1
      it's sad to see nobody care when i try to give some suggestion to improve dps in DefaultCombat .
       
    5. Cryogenesis

      Cryogenesis Moderator Moderator

      Joined:
      Jul 13, 2010
      Messages:
      2,128
      Likes Received:
      13
      Trophy Points:
      38
      If you have improved builds, please report them here: https://github.com/BosslandGmbH/BuddyWing.DefaultCombat/issues
      Best is that you discuss it first with pictures from a dps logger, that indicates, it really is an improvement.
      If you have troubles anywhere, pm me for help.
       
    6. Bender69

      Bender69 Community Developer

      Joined:
      Dec 31, 2015
      Messages:
      59
      Likes Received:
      0
      Trophy Points:
      0
      I can add them later there, but as said, I am changing it quite a bit, trying to add automatic interrupts for boss fights etc. Also dps is based on gear, aka some rotations work better with more alacrity and others with more crit. Some rotations just have personal preference and are based on Utility points.
       
    7. russ1979

      russ1979 Member

      Joined:
      Aug 25, 2011
      Messages:
      357
      Likes Received:
      0
      Trophy Points:
      16
      I'll give it a shot!
       
    8. russ1979

      russ1979 Member

      Joined:
      Aug 25, 2011
      Messages:
      357
      Likes Received:
      0
      Trophy Points:
      16
      So far looking pretty good on a Shield Tech BH. I'm liking it
       
    9. russ1979

      russ1979 Member

      Joined:
      Aug 25, 2011
      Messages:
      357
      Likes Received:
      0
      Trophy Points:
      16
      Something is not happy in Operative - Lethality

      2016-03-04 03:35:37,128 [Main Bot Thread] INFO Log - [BenderCombat] >> Casting << Carbine Burst
      2016-03-04 03:35:37,415 [Main Bot Thread] ERROR Log - System.NullReferenceException: Object reference not set to an instance of an object.
      at BenderCombat.Routines.Lethality.<get_SingleTarget>b__13(Object ret) in d:\Star Wars-The Old Republic\Killer\Routines\BenderCombat-master\Routines\Advanced\Operative\Lethality.cs:line 105
      at BenderCombat.Core.Spell.<>c__DisplayClass10.<Cast>b__d(Object ret) in d:\Star Wars-The Old Republic\Killer\Routines\BenderCombat-master\Core\Spell.cs:line 72
      at Buddy.BehaviorTree.Decorator.CanRun(Object context)
      at Buddy.BehaviorTree.Decorator.3\*:\[}^fnG^\.HVtHxC\*;6`F1o!.MoveNext()
      at (IEnumerator )
      at Buddy.BehaviorTree.Composite.Tick(Object context)
      at Buddy.BehaviorTree.PrioritySelector.V\*h(CLQ'\,=ifY@~\]{xP\\a\[QQ!.MoveNext()
      at (IEnumerator )
      at Buddy.BehaviorTree.Composite.Tick(Object context)
      at Buddy.BehaviorTree.PrioritySelector.V\*h(CLQ'\,=ifY@~\]{xP\\a\[QQ!.MoveNext()
      at (IEnumerator )
      at Buddy.BehaviorTree.Composite.Tick(Object context)
      at Buddy.BehaviorTree.Decorator.3\*:\[}^fnG^\.HVtHxC\*;6`F1o!.MoveNext()
      at (IEnumerator )
      at Buddy.BehaviorTree.Composite.Tick(Object context)
      at Buddy.BehaviorTree.PrioritySelector.V\*h(CLQ'\,=ifY@~\]{xP\\a\[QQ!.MoveNext()
      at (IEnumerator )
      at Buddy.BehaviorTree.Composite.Tick(Object context)
      at Buddy.Common.HookExecutor.Run(Object context)
      at Buddy.BehaviorTree.Action.RunAction(Object context)
      at Buddy.BehaviorTree.Action.fA'bs\&V~\.q7}$?Vej\]8pXLl\]".MoveNext()
      at (IEnumerator )
      at Buddy.BehaviorTree.Composite.Tick(Object context)
      at Buddy.BehaviorTree.Decorator.3\*:\[}^fnG^\.HVtHxC\*;6`F1o!.MoveNext()
      at (IEnumerator )
      at Buddy.BehaviorTree.Composite.Tick(Object context)
      at Buddy.BehaviorTree.PrioritySelector.V\*h(CLQ'\,=ifY@~\]{xP\\a\[QQ!.MoveNext()
      at (IEnumerator )
      at Buddy.BehaviorTree.Composite.Tick(Object context)
      at Buddy.BehaviorTree.Decorator.3\*:\[}^fnG^\.HVtHxC\*;6`F1o!.MoveNext()
      at (IEnumerator )
      at Buddy.BehaviorTree.Composite.Tick(Object context)
      at Buddy.CommonBot.BotMain.?????????????????????????????????????????()
      2016-03-04 03:35:38,554 [Main Bot Thread] INFO Log - [BenderCombat] >> Casting << Corrosive Dart
       
    10. russ1979

      russ1979 Member

      Joined:
      Aug 25, 2011
      Messages:
      357
      Likes Received:
      0
      Trophy Points:
      16
      Merc Aresenal no happy

      2016-03-04 09:07:26,997 [Main Bot Thread] ERROR Log - Engine class is null, TorObject may no longer be valid!
      2016-03-04 09:07:26,998 [Main Bot Thread] ERROR Log - System.Exception: DbOffset is Zero.
      at ?????????????????????????????????????????.?????????????????????????????????????????.?????????????????????????????????????????[](UInt64 , HeroType )
      at Buddy.Swtor.Objects.TorObject.GetField[T](DomFieldIds field, HeroType forcedType)
      at Buddy.Swtor.Objects.TorCharacter.get_InCombat()
      at BenderCombat.Helpers.Extensions.IsValidTarget(TorCharacter c) in d:\Star Wars-The Old Republic\Killer\Routines\BenderCombat-master\Helpers\Extensions.cs:line 217
      at BenderCombat.Core.Targeting.<get_ScanTargets>b__0(Object param0) in d:\Star Wars-The Old Republic\Killer\Routines\BenderCombat-master\Core\Targeting.cs:line 119
      at Buddy.BehaviorTree.Action.RunAction(Object context)
      at Buddy.BehaviorTree.Action.fA'bs\&V~\.q7}$?Vej\]8pXLl\]".MoveNext()
      at (IEnumerator )
      at Buddy.BehaviorTree.Composite.Tick(Object context)
      at Buddy.BehaviorTree.PrioritySelector.V\*h(CLQ'\,=ifY@~\]{xP\\a\[QQ!.MoveNext()
      at (IEnumerator )
      at Buddy.BehaviorTree.Composite.Tick(Object context)
      at Buddy.BehaviorTree.Decorator.3\*:\[}^fnG^\.HVtHxC\*;6`F1o!.MoveNext()
      at (IEnumerator )
      at Buddy.BehaviorTree.Composite.Tick(Object context)
      at Buddy.BehaviorTree.Decorator.3\*:\[}^fnG^\.HVtHxC\*;6`F1o!.MoveNext()
      at (IEnumerator )
      at Buddy.BehaviorTree.Composite.Tick(Object context)
      at Buddy.BehaviorTree.PrioritySelector.V\*h(CLQ'\,=ifY@~\]{xP\\a\[QQ!.MoveNext()
      at (IEnumerator )
      at Buddy.BehaviorTree.Composite.Tick(Object context)
      at Buddy.Common.HookExecutor.Run(Object context)
      at Buddy.BehaviorTree.Action.RunAction(Object context)
      at Buddy.BehaviorTree.Action.fA'bs\&V~\.q7}$?Vej\]8pXLl\]".MoveNext()
      at (IEnumerator )
      at Buddy.BehaviorTree.Composite.Tick(Object context)
      at Buddy.BehaviorTree.Decorator.3\*:\[}^fnG^\.HVtHxC\*;6`F1o!.MoveNext()
      at (IEnumerator )
      at Buddy.BehaviorTree.Composite.Tick(Object context)
      at Buddy.BehaviorTree.PrioritySelector.V\*h(CLQ'\,=ifY@~\]{xP\\a\[QQ!.MoveNext()
      at (IEnumerator )
      at Buddy.BehaviorTree.Composite.Tick(Object context)
      at Buddy.BehaviorTree.Decorator.3\*:\[}^fnG^\.HVtHxC\*;6`F1o!.MoveNext()
      at (IEnumerator )
      at Buddy.BehaviorTree.Composite.Tick(Object context)
      at Buddy.BehaviorTree.PrioritySelector.V\*h(CLQ'\,=ifY@~\]{xP\\a\[QQ!.MoveNext()
      at (IEnumerator )
      at Buddy.BehaviorTree.Composite.Tick(Object context)
      at Buddy.BehaviorTree.Decorator.3\*:\[}^fnG^\.HVtHxC\*;6`F1o!.MoveNext()
      at (IEnumerator )
      at Buddy.BehaviorTree.Composite.Tick(Object context)
      at Buddy.BehaviorTree.PrioritySelector.V\*h(CLQ'\,=ifY@~\]{xP\\a\[QQ!.MoveNext()
      at (IEnumerator )
      at Buddy.BehaviorTree.Composite.Tick(Object context)
      at Buddy.CommonBot.BotMain.?????????????????????????????????????????()
      2016-03-04 09:07:27,162 [Main Bot Thread] INFO Log - [BenderCombat] >> Casting << Priming Shot
      2016-03-04 09:07:27,339 [Main Bot Thread] INFO Log - [BenderCombat] >> Casting << Priming Shot
       
    11. Bender69

      Bender69 Community Developer

      Joined:
      Dec 31, 2015
      Messages:
      59
      Likes Received:
      0
      Trophy Points:
      0
      yeah not sure what those errors are, I was assuming they are normal DefaultCombat errors and not related to the rotation? I kept getting so many errors all the time, I stopped paying attention to them and just focused on what improved the dps.
       
    12. russ1979

      russ1979 Member

      Joined:
      Aug 25, 2011
      Messages:
      357
      Likes Received:
      0
      Trophy Points:
      16
      does not reconize the Merc healing spec bodyguard...default combat does not reconize that spec either
       
    13. Bighurt23

      Bighurt23 New Member

      Joined:
      Nov 10, 2012
      Messages:
      20
      Likes Received:
      0
      Trophy Points:
      1
      Watchmen works great. No more DPS stopping mid fight.
       
    14. xcure

      xcure Member

      Joined:
      Jan 15, 2010
      Messages:
      364
      Likes Received:
      1
      Trophy Points:
      18
      Does this support Sith Sorcerer? Thanks!
       
    15. Liq

      Liq New Member

      Joined:
      Oct 30, 2014
      Messages:
      6
      Likes Received:
      0
      Trophy Points:
      0
      Works much better than default combat for my trooper! Thanks so much!
       
    16. Ama

      Ama New Member

      Joined:
      Jun 6, 2011
      Messages:
      1,173
      Likes Received:
      33
      Trophy Points:
      0
      Rather than create an entire new CR, why don't you just submit a pull request on GitHub?
       
    17. alltrueist

      alltrueist Active Member

      Joined:
      Dec 10, 2012
      Messages:
      1,424
      Likes Received:
      16
      Trophy Points:
      38
      I don't think he created a new CR. When I first looked at it, he just copied a bunch of DefaultCombat stuff and made small changes.
       
    18. Praline

      Praline Member

      Joined:
      Aug 17, 2015
      Messages:
      149
      Likes Received:
      2
      Trophy Points:
      18
      OMG you're BAAACK!!! Please stay <chains Ama to bar stool>
      :)
       
    19. Cryogenesis

      Cryogenesis Moderator Moderator

      Joined:
      Jul 13, 2010
      Messages:
      2,128
      Likes Received:
      13
      Trophy Points:
      38
      And feeds the favourite drinks he wants! Parteeey parteeey!
       
    20. Asbonia

      Asbonia Member

      Joined:
      Jan 13, 2016
      Messages:
      94
      Likes Received:
      2
      Trophy Points:
      8
      Sith Assassin is spamming DARK CHARGE when started
       
      Last edited: Jan 13, 2017

    Share This Page